From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934155AbcKMMOh (ORCPT ); Sun, 13 Nov 2016 07:14:37 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:40373 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933745AbcKMMOg (ORCPT ); Sun, 13 Nov 2016 07:14:36 -0500 Subject: Re: [PATCH v4 10/26] staging: iio: tsl2583: fix comparison between signed and unsigned integers To: Brian Masney , linux-iio@vger.kernel.org References: <1478974781-1457-1-git-send-email-masneyb@onstation.org> <1478974781-1457-11-git-send-email-masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com From: Jonathan Cameron Message-ID: Date: Sun, 13 Nov 2016 12:14:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478974781-1457-11-git-send-email-masneyb@onstation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/16 18:19, Brian Masney wrote: > Fixed warning found by make W=2: > > warning: comparison between signed and unsigned integer expressions > [-Wsign-compare] > > Signed-off-by: Brian Masney Applied. > --- > drivers/staging/iio/light/tsl2583.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c > index d482a84..be3cbae 100644 > --- a/drivers/staging/iio/light/tsl2583.c > +++ b/drivers/staging/iio/light/tsl2583.c > @@ -510,7 +510,7 @@ static ssize_t in_illuminance_lux_table_show(struct device *dev, > struct device_attribute *attr, > char *buf) > { > - int i; > + unsigned int i; > int offset = 0; > > for (i = 0; i < ARRAY_SIZE(tsl2583_device_lux); i++) { > @@ -541,7 +541,8 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev, > struct iio_dev *indio_dev = dev_to_iio_dev(dev); > struct tsl2583_chip *chip = iio_priv(indio_dev); > int value[ARRAY_SIZE(tsl2583_device_lux) * 3 + 1]; > - int n, ret = -EINVAL; > + int ret = -EINVAL; > + unsigned int n; > > mutex_lock(&chip->als_mutex); > > @@ -719,7 +720,7 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev, > break; > case IIO_CHAN_INFO_CALIBSCALE: > if (chan->type == IIO_LIGHT) { > - int i; > + unsigned int i; > > for (i = 0; i < ARRAY_SIZE(gainadj); i++) { > if (gainadj[i].mean == val) { >