From: Pavel Skripkin <paskripkin@gmail.com>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: Johan Hovold <johan@kernel.org>,
wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
kuba@kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] can: etas_es58x: fix error handling
Date: Mon, 15 Nov 2021 12:26:56 +0300 [thread overview]
Message-ID: <af7d7175-730e-5a41-4cff-92c2554010d9@gmail.com> (raw)
In-Reply-To: <CAMZ6Rq+3uPE31q=HN-BdkXsMYZf53=VfNSn0OD6HcweLO0u-_Q@mail.gmail.com>
On 11/15/21 12:24, Vincent MAILHOL wrote:
>> Sure! I should have check it before sending v2 :( My bad, sorry. I see
>> now, that there is possible calltrace which can hit NULL defer.
>
> I should be the one apologizing here. Sorry for the confusion.
>
>> One thing I am wondering about is why in some code parts there are
>> validation checks for es58x_dev->netdev[i] and in others they are missing.
>
> There is a validation when it is accessed in a for loop.
> It is not guarded in es58x_send_msg() because this function
> expects the channel_idx to be a valid index.
>
> Does this answer your wonders?
>
Yeah! I have just looked at the code one more time and came up with the
same idea.
Thank you for confirming and acking my patch :)
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-11-15 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 20:58 [PATCH] can: etas_es58x: fix error handling Pavel Skripkin
2021-11-15 5:27 ` Vincent MAILHOL
2021-11-15 7:40 ` Pavel Skripkin
2021-11-15 7:51 ` [PATCH v2] " Pavel Skripkin
2021-11-15 8:11 ` Johan Hovold
2021-11-15 8:15 ` Pavel Skripkin
2021-11-15 8:16 ` Johan Hovold
2021-11-15 8:30 ` Pavel Skripkin
2021-11-15 9:24 ` Vincent MAILHOL
2021-11-15 9:26 ` Pavel Skripkin [this message]
2021-11-15 8:37 ` [PATCH v3] " Pavel Skripkin
2021-11-15 9:15 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af7d7175-730e-5a41-4cff-92c2554010d9@gmail.com \
--to=paskripkin@gmail.com \
--cc=davem@davemloft.net \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).