From: Eric Dumazet <eric.dumazet@gmail.com>
To: Wen Yang <wenyang@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
davem@davemloft.net
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp_bbr: improve arithmetic division in bbr_update_bw()
Date: Mon, 20 Jan 2020 09:58:23 -0800 [thread overview]
Message-ID: <af89b1c6-2182-be2e-6b44-1921483d426b@gmail.com> (raw)
In-Reply-To: <20200120100456.45609-1-wenyang@linux.alibaba.com>
On 1/20/20 2:04 AM, Wen Yang wrote:
> do_div() does a 64-by-32 division. Use div64_long() instead of it
> if the divisor is long, to avoid truncation to 32-bit.
> And as a nice side effect also cleans up the function a bit.
>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2020-01-20 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 10:04 [PATCH] tcp_bbr: improve arithmetic division in bbr_update_bw() Wen Yang
2020-01-20 17:58 ` Eric Dumazet [this message]
2020-01-21 9:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af89b1c6-2182-be2e-6b44-1921483d426b@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenyang@linux.alibaba.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).