From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2]: perf record: enable asynchronous trace writing
Date: Thu, 6 Sep 2018 14:57:16 +0300 [thread overview]
Message-ID: <af8cc53e-b6c3-9a28-6f66-45817b65badc@linux.intel.com> (raw)
In-Reply-To: <20180906110400.GD8248@krava>
On 06.09.2018 14:04, Jiri Olsa wrote:
> On Wed, Sep 05, 2018 at 10:39:25AM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> -static int record__pushfn(void *to, void *bf, size_t size)
>> +static int record__pushfn(void *to, struct aiocb *cblock, void *data, size_t size)
>> {
>> + off_t off;
>> struct record *rec = to;
>> + int ret, trace_fd = rec->session->data->file.fd;
>>
>> rec->samples++;
>> - return record__write(rec, bf, size);
>> +
>> + off =
>> + lseek(trace_fd, 0, SEEK_CUR);
>> + lseek(trace_fd, off + size, SEEK_SET);
>> +
>> + ret = record__aio_write(cblock, trace_fd, data, size, off);
>> + if (!ret) {
>> + rec->bytes_written += size;
>> + if (switch_output_size(rec))
>> + trigger_hit(&switch_output_trigger);
>
> why do you need to call switch output from here?
Just preserved this logic from the serial implementation.
>
> jirka
>
next prev parent reply other threads:[~2018-09-06 11:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:16 [PATCH v7 0/2]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-09-05 7:19 ` [PATCH v7 1/2]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:50 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:54 ` Alexey Budankov
2018-09-05 7:39 ` [PATCH v7 2/2]: perf record: enable asynchronous trace writing Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:57 ` Alexey Budankov [this message]
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:58 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 11:59 ` Alexey Budankov
2018-09-06 11:04 ` Jiri Olsa
2018-09-06 12:09 ` Alexey Budankov
2018-09-05 11:28 ` [PATCH v7 0/2]: perf: reduce data loss when profiling highly parallel CPU bound workloads Jiri Olsa
2018-09-05 17:37 ` Alexey Budankov
2018-09-05 18:51 ` Arnaldo Carvalho de Melo
2018-09-06 6:03 ` Alexey Budankov
2018-09-06 8:14 ` Jiri Olsa
2018-09-06 8:20 ` Alexey Budankov
2018-09-06 6:59 ` Alexey Budankov
2018-09-06 6:57 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af8cc53e-b6c3-9a28-6f66-45817b65badc@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).