linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, Jeremy Cline <jeremy@jcline.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Bluetooth regression breaking BT connection for all 2.0 and older devices in 5.0.15+, 5.1.x and master
Date: Mon, 10 Jun 2019 15:31:55 +0200	[thread overview]
Message-ID: <af8cf6f4-4979-2f6f-68ed-e5b368b17ec7@redhat.com> (raw)

Hi All,

First of all this is a known issue and it seems a fix is in the works,
but what I do not understand is why the commit causing this has not
simply been reverted until the fix is done, esp. for the 5.0.x
stable series where this was introduced in 5.0.15.

The problem I'm talking about is commit d5bb334a8e17 ("Bluetooth: Align
minimum encryption key size for LE and BR/EDR connections"):
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5bb334a8e171b262e48f378bd2096c0ea458265
basically completely breaking all somewhat older (and some current cheap
no-name) bluetooth devices:

A revert of this was first proposed on May 22nd:
https://lore.kernel.org/netdev/CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v3HB9eA@mail.gmail.com/T/
We are 18 days further now and this problem still exists, including in the
5.0.15+ and 5.1.x stable kernels.

A solution has been suggested: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtmann.org/T/#u
and at least the Fedora 5.1.4+ kernels now carry this as a temporary fix,
but as of today I do not see a fix nor a revert in Torvald's tree yet and
neither does there seem to be any fix in the 5.0.x and 5.1.x stable series.

In the mean time we are getting a lot of bug reports about this:
https://bugzilla.kernel.org/show_bug.cgi?id=203643
https://bugzilla.redhat.com/show_bug.cgi?id=1711468
https://bugzilla.redhat.com/show_bug.cgi?id=1713871
https://bugzilla.redhat.com/show_bug.cgi?id=1713980

And some reporters:
https://bugzilla.redhat.com/show_bug.cgi?id=1713871#c4
Are indicating that the Fedora kernels with the workaround included
still do not work...

As such I would like to suggest that we just revert the troublesome
commit for now and re-add it when we have a proper fix.

Regards,

Hans



             reply	other threads:[~2019-06-10 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 13:31 Hans de Goede [this message]
2019-06-10 14:46 ` Bluetooth regression breaking BT connection for all 2.0 and older devices in 5.0.15+, 5.1.x and master Greg Kroah-Hartman
2019-06-13  7:35 ` Greg Kroah-Hartman
2019-06-20  9:25   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af8cf6f4-4979-2f6f-68ed-e5b368b17ec7@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremy@jcline.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).