linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ayaka <ayaka@soulik.info>
To: Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	mark.rutland@arm.com
Subject: Re: [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for firefly reload
Date: Sun, 14 Aug 2016 20:38:59 +0800	[thread overview]
Message-ID: <af99cf05-dfc7-1ae6-8d23-f33298b5f683@soulik.info> (raw)
In-Reply-To: <35898684.O6p1GdTFI2@phil>



On 08/14/2016 08:30 PM, Heiko Stuebner wrote:
> Am Sonntag, 14. August 2016, 19:27:23 CEST schrieb Randy Li:
>> Because of a bug in hardware design, the sdcard at firefly
>> rk3288 reload board can't switch the io voltage level to 1.8v.
>>
>> Signed-off-by: Randy Li <ayaka@soulik.info>
>> ---
>>   arch/arm/boot/dts/rk3288-firefly-reload.dts | 7 +------
>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts
>> b/arch/arm/boot/dts/rk3288-firefly-reload.dts index 43145d1..a2b1f14 100644
>> --- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
>> +++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
>> @@ -202,18 +202,13 @@
>>   	bus-width = <4>;
>>   	cap-mmc-highspeed;
>>   	cap-sd-highspeed;
>> -	sd-uhs-sdr12;
>> -	sd-uhs-sdr25;
>> -	sd-uhs-sdr50;
>> -	sd-uhs-sdr104;
>> -	sd-uhs-ddr50;
>>   	card-detect-delay = <200>;
>>   	disable-wp;
>>   	num-slots = <1>;
>>   	pinctrl-names = "default";
>>   	pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
>>   	vmmc-supply = <&vcc_sd>;
>> -	vqmmc-supply = <&vccio_sd>;
>> +	vqmmc-supply = <&vcc_sd>;
> that looks wrong. vccio_sd is still the vqmmc supply in the schematics even
> though we don't want to switch to 1.8V . But that regulator should still be
I think the vccio_sd is just the one connected to the io_domains, but 
the voltage source for the
pull up register is not vccio_sd but vcc_io.
> controllable without needing a regulator-always-on in the future.
>
>
> Heiko

  reply	other threads:[~2016-08-14 12:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1549971.ctkvOGm2xW@diego>
2016-07-18 15:32 ` [PATCH v2] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-18 15:32   ` [PATCH] " Randy Li
2016-07-18 19:46     ` Heiko Stübner
2016-08-07  3:40       ` Shawn Lin
2016-08-07 14:44         ` Heiko Stuebner
2016-08-08  2:29           ` Shawn Lin
2016-08-09  9:28           ` 陈豪
2016-08-09 10:02             ` 陈豪
2016-08-09 10:06               ` Randy Li
2016-08-09 10:58                 ` Heiko Stübner
2016-08-10  1:12                   ` Randy Li
2016-08-14 11:27                     ` [PATCH 0/2] ARM: dts: rockchip: correct the regulators in firefly reload Randy Li
2016-08-14 11:27                       ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li
2016-08-14 12:30                         ` Heiko Stuebner
2016-08-14 12:38                           ` ayaka [this message]
2016-08-17 14:10                             ` Heiko Stübner
2016-08-17 17:03                               ` [PATCH 0/2 v2] ARM: dts: rockchip: correct the regulators in " Randy Li
2016-08-17 17:03                                 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li
2016-08-18 13:35                                   ` Heiko Stübner
2016-08-18 14:20                                     ` ayaka
2016-08-17 17:03                                 ` [PATCH 2/2] ARM: dts: rockchip: add missing regulators for firefly reload board Randy Li
2016-08-18 16:47                                   ` Heiko Stübner
2016-08-14 11:27                       ` Randy Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af99cf05-dfc7-1ae6-8d23-f33298b5f683@soulik.info \
    --to=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).