From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22EC2C433E9 for ; Mon, 11 Jan 2021 06:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7FD622581 for ; Mon, 11 Jan 2021 06:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727305AbhAKG0V (ORCPT ); Mon, 11 Jan 2021 01:26:21 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:38392 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbhAKG0V (ORCPT ); Mon, 11 Jan 2021 01:26:21 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610346362; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Y66XF+Djddn7k3iYTGrUGms1lzGNsW9OD4rOjfjlTmE=; b=fdCb0Dh1ZNZHo81bgsCeq1vpT9cBPJMbufafIAHNY6YSMFa0nT5JQjVIzWVNfskPGwih7A1X +vNrSYmEY5Czdzdq2oJbWYn7VgkDw17A1tw+DbDi7mvXor7Y3dIwJEH2NtDVGWYY/rNqjc69 Nx6GYeo+8rR+3upAxn77AOi5m7w= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5ffbef59c88af06107e5d797 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 11 Jan 2021 06:25:29 GMT Sender: pnagar=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E99EDC43465; Mon, 11 Jan 2021 06:25:28 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pnagar) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2BF48C433CA; Mon, 11 Jan 2021 06:25:28 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Jan 2021 11:55:28 +0530 From: pnagar@codeaurora.org To: Miguel Ojeda Cc: Arnd Bergmann , jmorris@namei.org, serge@hallyn.com, paul@paul-moore.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, linux-security-module , selinux@vger.kernel.org, linux-arch , psodagud@codeaurora.org, nmardana@codeaurora.org, dsule@codeaurora.org, Joe Perches , Miguel Ojeda , Nick Desaulniers , linux-kernel Subject: Re: [RFC PATCH v2] selinux: security: Move selinux_state to a separate page In-Reply-To: References: <1610099389-28329-1-git-send-email-pnagar@codeaurora.org> Message-ID: X-Sender: pnagar@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-08 20:55, Miguel Ojeda wrote: > On Fri, Jan 8, 2021 at 10:52 AM Preeti Nagar > wrote: >> >> We want to seek your suggestions and comments on the idea and the >> changes >> in the patch. > > Not sure why I was Cc'd, but I have a quick comment nevertheless. > >> +#ifdef CONFIG_SECURITY_RTIC >> +struct selinux_state selinux_state __rticdata; >> +#else >> struct selinux_state selinux_state; >> +#endif > > If you define an empty __rticdata for the !CONFIG case, then we don't > need #ifdefs for uses like this. > > Cheers, > Miguel Thank you for the review! Will update this change in the next version of the patch soon. Thanks, Preeti