From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF42C3A5A4 for ; Wed, 28 Aug 2019 08:35:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C141B214DA for ; Wed, 28 Aug 2019 08:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbfH1If0 (ORCPT ); Wed, 28 Aug 2019 04:35:26 -0400 Received: from mga02.intel.com ([134.134.136.20]:38561 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfH1IfZ (ORCPT ); Wed, 28 Aug 2019 04:35:25 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 01:35:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="264571781" Received: from deyangko-mobl.ccr.corp.intel.com ([10.249.168.35]) by orsmga001.jf.intel.com with ESMTP; 28 Aug 2019 01:35:21 -0700 Message-ID: Subject: Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations From: Zhang Rui To: Leonard Crestez , Anson Huang , Shawn Guo Cc: Eduardo Valentin , Daniel Lezcano , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , Stephen Boyd , Andrey Smirnov Date: Wed, 28 Aug 2019 16:35:29 +0800 In-Reply-To: References: <20190730022126.17883-1-Anson.Huang@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > On Tue, 2019-08-27 at 12:41 +0000, Leonard Crestez wrote: > > On 27.08.2019 04:51, Anson Huang wrote: > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > > the TMU > > > > clock so if the thermal driver doesn't explicitly enable it the > > > > system will hang > > > > on probe. This is what happens in linux-next right now! > > > > > > The thermal driver should be built with module, so default kernel > > > should can boot > > > up, do you modify the thermal driver as built-in? > > > > > > > Unless this patches is merged soon we'll end up with a 5.4-rc1 > > > > that doesn't > > > > boot on imx8mq. An easy fix would be to drop/revert commit > > > > 951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for > > > > IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted. > > > > > > If the thermal driver is built as module, I think no need to > > > revert > > > the commit, but > > > if by default thermal driver is built-in or mod probed, then yes, > > > it should NOT break > > > kernel boot up. > > > > The qoriq_thermal driver is built as a module in defconfig and > > when > > modules are properly installed in rootfs they will be automatically > > be > > probed on boot and cause a hang. > > > > I usually run nfsroot with modules: > > > > make modules_install INSTALL_MOD_PATH=/srv/nfs/imx8-root > > so we need this patch shipped in the beginning of the merge window, > right? > if there is hard dependency between patches, it's better to send them > in one series, and get shipped via either tree. > > BTW, who is maintaining qoriq driver from NXP? If Anson is > maintaining > and developing this driver, it's better to update this in the driver > or > the MAINTAINER file, I will take the driver specific patches as long > as > we have ACK/Reviewed-By from the driver maintainer. And also, can you provide your feedback for this one? https://patchwork.kernel.org/patch/10974147/ thanks, rui > > thanks, > rui > > > > > -- > > Regards, > > Leonard