From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76201C4338F for ; Tue, 27 Jul 2021 09:26:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A37F61362 for ; Tue, 27 Jul 2021 09:26:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236118AbhG0J0b (ORCPT ); Tue, 27 Jul 2021 05:26:31 -0400 Received: from relay.sw.ru ([185.231.240.75]:37346 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236140AbhG0J0Y (ORCPT ); Tue, 27 Jul 2021 05:26:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:Subject :From; bh=aA4OKvIJX54mPh9QQGvJAgE1NSRLlK28/A5Ft+jS4wk=; b=jEfB9MJFSdPNiqdCXAZ 3Z62IS2ffQzJuMY15RKM/nZj2NYL3YFhbyT+VsHbbsPTdRe+NwSfHQGgrtyYhaB99zj3vqsE9f1If Spm8IT/7BVz3qp2ClvJzlF10US7VmxGpWgxtKo3esF27NAaRlPfO6ZBAwV4PiZMazGttnQltqCg=; Received: from [10.93.0.56] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1m8JLo-005MwK-TY; Tue, 27 Jul 2021 12:26:12 +0300 From: Vasily Averin Subject: [PATCH TTY] memcg: drop GFP_KERNEL_ACCOUNT use in tty_save_termios() To: Jiri Slaby , Greg Kroah-Hartman Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: Message-ID: Date: Tue, 27 Jul 2021 12:26:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Slaby pointed that termios are not saved for PTYs and for other terminals used inside containers. Therefore accounting for saved termios have near to zero impact in real life scenarios. Cc: Jiri Slaby Fixes: 854dd8a572a0 ("memcg: enable accounting for tty-related objects") Signed-off-by: Vasily Averin --- drivers/tty/tty_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index e787f6f..a6230b2 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -1493,7 +1493,7 @@ void tty_save_termios(struct tty_struct *tty) /* Stash the termios data */ tp = tty->driver->termios[idx]; if (tp == NULL) { - tp = kmalloc(sizeof(*tp), GFP_KERNEL_ACCOUNT); + tp = kmalloc(sizeof(*tp), GFP_KERNEL); if (tp == NULL) return; tty->driver->termios[idx] = tp; -- 1.8.3.1