From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E107C43457 for ; Wed, 14 Oct 2020 07:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5373B21582 for ; Wed, 14 Oct 2020 07:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728517AbgJNH7G (ORCPT ); Wed, 14 Oct 2020 03:59:06 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:53394 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727306AbgJNH7C (ORCPT ); Wed, 14 Oct 2020 03:59:02 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DC266E15FA1BFE7BA172; Wed, 14 Oct 2020 15:58:55 +0800 (CST) Received: from [127.0.0.1] (10.174.177.134) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 14 Oct 2020 15:58:54 +0800 Subject: Re: [PATCH] dt-bindings: leds: Update devicetree documents for ID_RGB To: Dan Murphy , , CC: , , References: <20201013175034.25911-1-dmurphy@ti.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Wed, 14 Oct 2020 15:58:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20201013175034.25911-1-dmurphy@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.134] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/14 1:50, Dan Murphy wrote: > Update the leds/common.yaml to indicate that the max color ID is 9. > Reflect the same change in the leds-class-multicolor.yaml > > Reported-by: Zhen Lei > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/leds/common.yaml | 2 +- > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 9 +++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > index a2a541bca73c..0c9f912dfee6 100644 > --- a/Documentation/devicetree/bindings/leds/common.yaml > +++ b/Documentation/devicetree/bindings/leds/common.yaml > @@ -43,7 +43,7 @@ properties: > LED_COLOR_ID available, add a new one. > $ref: /schemas/types.yaml#definitions/uint32 > minimum: 0 > - maximum: 8 > + maximum: 9 > > function-enumerator: > description: > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > index b55e1f1308a4..f8032e863ecb 100644 > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > @@ -16,7 +16,7 @@ description: | > modules. This is achieved by adding multi-led nodes layer to the > monochrome LED bindings. > The nodes and properties defined in this document are unique to the multicolor > - LED class. Common LED nodes and properties are inherited from the common.txt > + LED class. Common LED nodes and properties are inherited from the common.yaml > within this documentation directory. > > patternProperties: > @@ -25,10 +25,11 @@ patternProperties: > description: Represents the LEDs that are to be grouped. > properties: > color: > - const: 8 # LED_COLOR_ID_MULTI > + const: 9 # LED_COLOR_ID_RGB This means only LED_COLOR_ID_RGB is allowed. > description: | > - For multicolor LED support this property should be defined as > - LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h. > + For multicolor LED support this property should be defined as either > + LED_COLOR_ID_RGB or LED_COLOR_ID_MULTI which can be found in If both LED_COLOR_ID_RGB and LED_COLOR_ID_MULTI are allowed, then we should use enum list both of them. > + include/linux/leds/common.h. > > $ref: "common.yaml#" > >