From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72BCFC433FC for ; Tue, 28 Jul 2020 07:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47832207E8 for ; Tue, 28 Jul 2020 07:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="uX2vLSo6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbgG1HUO (ORCPT ); Tue, 28 Jul 2020 03:20:14 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:38766 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726990AbgG1HUM (ORCPT ); Tue, 28 Jul 2020 03:20:12 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595920811; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=kRmZCJyj9I1SnPZs5XwOYPOfxafRktfoOSamzdqNY1M=; b=uX2vLSo6OuTUy0g1fQlQyCuFP0WjWBFx0ChJ8mz301pSiGRqRBwjmW0kd2XeezJ936+PQdEG yESucXmTNYFmD+K+r+b4T8NWAnzhHDRMux6vYgoQgFl+0LMWvOs1PcLPL6OPgLHrI55zZvgB BE1FiEFYVbCju2UtIwst5iYeHXQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f1fd1a77ab15087eb4700dc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Jul 2020 07:20:07 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B99AFC433AD; Tue, 28 Jul 2020 07:20:06 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id D6338C433C9; Tue, 28 Jul 2020 07:20:05 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jul 2020 12:50:05 +0530 From: Sai Prakash Ranjan To: Bjorn Andersson Cc: Andy Gross , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Mathieu Poirier , Suzuki K Poulose , mike.leach@linaro.org, Jonathan Marek Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR In-Reply-To: <20200728062850.GC202429@builder.lan> References: <2312c9a10e7251d69e31e4f51c0f1d70e6f2f2f5.1591708204.git.saiprakash.ranjan@codeaurora.org> <20200621072213.GG128451@builder.lan> <20200727205834.GA202429@builder.lan> <207e6b6a297d5ce1bdcac204e297389b@codeaurora.org> <20200728062850.GC202429@builder.lan> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-28 11:58, Bjorn Andersson wrote: > On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: > >> On 2020-07-28 02:28, Bjorn Andersson wrote: >> > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: >> > >> > > Hi Bjorn, >> > > >> > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: >> > > > Hi Bjorn, >> > > > >> > > > On 2020-06-21 12:52, Bjorn Andersson wrote: >> > > > > On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: >> > > > > >> > > > > > Define iommus property for Coresight ETR component in >> > > > > > SC7180 SoC with the SID and mask to enable SMMU >> > > > > > translation for this master. >> > > > > > >> > > > > >> > > > > We don't have &apps_smmu in linux-next, as we've yet to figure out how >> > > > > to disable the boot splash or support the stream mapping handover. >> > > > > >> > > > > So I'm not able to apply this. >> > > > > >> > > > >> > > > This is for SC7180 which has apps_smmu not SM8150. >> > > > >> > > >> > > Please let me know if this needs further explanation. >> > > >> > >> > I must have commented on the wrong patch, sorry about that. The SM8150 >> > patch in this series does not compile due to the lack of &apps_smmu. >> > >> > I've picked the other 3 patches. >> > >> >> Thanks Bjorn, I can resend SM8150 coresight change when SMMU support >> lands >> for it >> since coresight ETR won't work without it on android bootloaders. >> >> As for the other 3 patches, Patch 1 and Patch 2 will apply cleanly to >> the >> right coresight >> nodes but due to the missing unique context in Patch 3, it could be >> applied >> to some other node. >> We had to upload this change 3 times in chromium tree to get it >> applied to >> the right replicator node :) >> and this property in Patch 3 is important to fix a hard lockup. I'm >> not sure >> why this patch is missing >> the proper context :/ >> >> I couldn't find the changes yet in qcom/for-next or other branches to >> see if >> it is >> applied to right replicator node. In case you haven't applied it yet, >> Patch >> 3 change >> should be applied to "replicator@6b06000" node. >> > > Thanks for pointing that out, I've fixed up the incorrectly applied > change. (Still not published the branch) > > > For the future I believe you can pass -U to git format-patch to get > number of lines of context. Making that bigger than the default 3 > should help for the coresight patches. > Thanks Bjorn, will use this option going forward. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation