From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: cocci <cocci@systeme.lip6.fr>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: cocci script to convert linux-kernel allocs with BITS_TO_LONGS to bitmap_alloc
Date: Sat, 10 Jul 2021 13:02:36 -0700 [thread overview]
Message-ID: <afd3a282ca57a4a400c8bae9879a7c57bc507c59.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2107102149140.46528@hadrien>
On Sat, 2021-07-10 at 21:50 +0200, Julia Lawall wrote:
> On Fri, 9 Jul 2021, Joe Perches wrote:
>
> > Here is a cocci script to convert various types of bitmap allocations
> > that use BITS_TO_LONGS to the more typical bitmap_alloc functions.
> >
> > Perhaps something like it could be added to scripts/coccinelle.
> > The diff produced by the script is also below.
> >
> > $ cat bitmap_allocs.cocci
> > // typical uses of bitmap allocations
[]
> > @@
> > expression val;
> > expression e1;
> > expression e2;
> > @@
> >
> > - val = kcalloc(BITS_TO_LONGS(e1), sizeof(*val), e2)
> > + val = bitmap_zalloc(e1, e2)
>
> Is there something that guarantees that val has a type that has a size that
> is the same as a long?
no, but afaict, all do.
next prev parent reply other threads:[~2021-07-10 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 20:39 cocci script to convert linux-kernel allocs with BITS_TO_LONGS to bitmap_alloc Joe Perches
2021-07-10 19:50 ` Julia Lawall
2021-07-10 20:02 ` Joe Perches [this message]
2021-07-10 20:09 ` Julia Lawall
2021-07-13 21:33 ` Julia Lawall
2021-07-13 23:09 ` Joe Perches
2021-07-14 6:22 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd3a282ca57a4a400c8bae9879a7c57bc507c59.camel@perches.com \
--to=joe@perches.com \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).