From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E181C388F9 for ; Tue, 27 Oct 2020 08:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B51DD2224E for ; Tue, 27 Oct 2020 08:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603788679; bh=8dUViDF5AY6tlMc5Zv1B0uvXiJWKjdjrfSA2hyJnu28=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=IrIVHHlhdu5wnZPbA1uUNO9nUwLvFRXYsEh1ZX6ER0ZyQbUogrgG23lC4nE5ZeXQr HJRTSRqefhnrRC/8bI0dD76mFHiRCUqsTCssE6AYPiFSFEFEBUa1Lx4FTSLaK4o0MU 9D/6K8nY7UY/tKNgdelD/i3teW+yuWuMt9nPU2/M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2509485AbgJ0IvS (ORCPT ); Tue, 27 Oct 2020 04:51:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:52770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2509468AbgJ0IvS (ORCPT ); Tue, 27 Oct 2020 04:51:18 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC80B207DE; Tue, 27 Oct 2020 08:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603788678; bh=8dUViDF5AY6tlMc5Zv1B0uvXiJWKjdjrfSA2hyJnu28=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=waBWXHTqt80D98RIveVBsQt6EJGt9YZqLHtwaRK9rAclMOx08LZIK9YMmqSaqOtvH YjA/f8lhEIZG3jfMjd74abkaEl4Cp49JUn/1zfsGXdBVEpABFHKaAI/ukFV+EM6TGk omphyMaLuYEjNhCsXtta74oQ9l+Z7bSCz4RQ9MnY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kXKhH-004cXA-IH; Tue, 27 Oct 2020 08:51:15 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 27 Oct 2020 08:51:15 +0000 From: Marc Zyngier To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zhen Lei Subject: Re: [PATCH AUTOSEL 5.9 087/147] genirq: Add stub for set_handle_irq() when !GENERIC_IRQ_MULTI_HANDLER In-Reply-To: <20201026234905.1022767-87-sashal@kernel.org> References: <20201026234905.1022767-1-sashal@kernel.org> <20201026234905.1022767-87-sashal@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, thunder.leizhen@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-26 23:48, Sasha Levin wrote: > From: Zhen Lei > > [ Upstream commit ea0c80d1764449acf2f70fdb25aec33800cd0348 ] > > In order to avoid compilation errors when a driver references > set_handle_irq(), > but that the architecture doesn't select GENERIC_IRQ_MULTI_HANDLER, > add a stub function that will just WARN_ON_ONCE() if ever used. > > Signed-off-by: Zhen Lei > [maz: commit message] > Signed-off-by: Marc Zyngier > Link: > https://lore.kernel.org/r/20200924071754.4509-2-thunder.leizhen@huawei.com > Signed-off-by: Sasha Levin > --- > include/linux/irq.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/irq.h b/include/linux/irq.h > index 1b7f4dfee35b3..b167baef88c0b 100644 > --- a/include/linux/irq.h > +++ b/include/linux/irq.h > @@ -1252,6 +1252,12 @@ int __init set_handle_irq(void > (*handle_irq)(struct pt_regs *)); > * top-level IRQ handler. > */ > extern void (*handle_arch_irq)(struct pt_regs *) __ro_after_init; > +#else > +#define set_handle_irq(handle_irq) \ > + do { \ > + (void)handle_irq; \ > + WARN_ON(1); \ > + } while (0) > #endif > > #endif /* _LINUX_IRQ_H */ What is the reason for this backport? The only user is a driver that isn't getting backported (d59f7d159891 and following patches). Thanks, M. -- Jazz is not dead. It just smells funny...