From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FB5C63697 for ; Mon, 23 Nov 2020 22:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D563206B7 for ; Mon, 23 Nov 2020 22:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731159AbgKWWYM (ORCPT ); Mon, 23 Nov 2020 17:24:12 -0500 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:34174 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728161AbgKWWYL (ORCPT ); Mon, 23 Nov 2020 17:24:11 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 3C1C0100E7B43; Mon, 23 Nov 2020 22:24:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: skin07_30012d527369 X-Filterd-Recvd-Size: 4485 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Mon, 23 Nov 2020 22:24:08 +0000 (UTC) Message-ID: Subject: [RFC PATCH] Add a new "Frozen" status to MAINTAINERS subsystem entries From: Joe Perches To: Sam Ravnborg , Bernard Zhao Cc: linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , kernel-janitors , Greg KH Date: Mon, 23 Nov 2020 14:24:07 -0800 In-Reply-To: <20201123214208.GB675342@ravnborg.org> References: <20201119072957.108941-1-bernard@vivo.com> <20201123214208.GB675342@ravnborg.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-11-23 at 22:42 +0100, Sam Ravnborg wrote: > For this old driver we should try to limit patches to bug fixing and > infrastructure updates. It might be useful to add a new "S:" entry type to these old drivers as supported/maintained/obsolete may not really be appropriate. How about something like "S: Frozen" and checkpatch could emit a message similar to the one for unnecessary changes to obsolete code? So using the below would emit: $ ./scripts/checkpatch.pl -f drivers/gpu/drm/via/via_dma.c WARNING: drivers/gpu/drm/via/via_dma.c is marked as 'frozen' in the MAINTAINERS hierarchy. No unnecessary modifications please. Maybe like the below (and fyi there's no additional git lookup overhead as the initial obsolete check already caches the git result). --- MAINTAINERS | 10 +++++++++- scripts/checkpatch.pl | 11 +++++++---- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5f10105cac6f..6374d29180b8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -88,7 +88,10 @@ Descriptions of section entries and preferred order Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. Odd Fixes: It has a maintainer but they don't have time to do - much other than throw the odd patch in. See below.. + much other than throw the odd patch in. + Frozen: Old code that should not be modified unless changes + are to correct actual defects or API infrastructure. + Cleanup/style changes are not generally accepted. Orphan: No current maintainer [but maybe you could take the role as you write your new code]. Obsolete: Old code. Something tagged obsolete generally means @@ -5718,6 +5721,11 @@ S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc F: drivers/gpu/drm/udl/ +DRM DRIVER FOR VIA +L: dri-devel@lists.freedesktop.org +S: Frozen +F: drivers/gpu/drm/via/ + DRM DRIVER FOR VIRTUAL KERNEL MODESETTING (VKMS) M: Rodrigo Siqueira M: Melissa Wen diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index fdfd5ec09be6..79321cbfb761 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -902,8 +902,8 @@ sub seed_camelcase_file { our %maintained_status = (); -sub is_maintained_obsolete { - my ($filename) = @_; +sub is_maintained { + my ($filename, $test) = @_; return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl")); @@ -911,7 +911,7 @@ sub is_maintained_obsolete { $maintained_status{$filename} = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`; } - return $maintained_status{$filename} =~ /obsolete/i; + return $maintained_status{$filename} =~ /$test/i; } sub is_SPDX_License_valid { @@ -2633,9 +2633,12 @@ sub process { } if ($found_file) { - if (is_maintained_obsolete($realfile)) { + if (is_maintained($realfile, "obsolete")) { WARN("OBSOLETE", "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.\n"); + } elsif (is_maintained($realfile, "frozen")) { + WARN("FROZEN", + "$realfile is marked as 'frozen' in the MAINTAINERS hierarchy. No unnecessary modifications please.\n"); } if ($realfile =~ m@^(?:drivers/net/|net/|drivers/staging/)@) { $check = 1;