linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Olof Johansson" <olof@lixom.net>,
	ARM <linux-arm-kernel@lists.infradead.org>
Cc: "Rob Herring" <robh@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: linux-next: build warning after merge of the arm-soc tree
Date: Thu, 22 Jun 2023 10:19:17 +0200	[thread overview]
Message-ID: <afeb9fad-0d3b-48ac-82da-218dcd8010e7@app.fastmail.com> (raw)
In-Reply-To: <20230622104810.30055fb1@canb.auug.org.au>

On Thu, Jun 22, 2023, at 02:48, Stephen Rothwell wrote:
> Hi all,
>
> After merging the arm-soc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning 
> (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format 
> error, expected "0"
>
> I am not sure why this has only shown up now.

Thanks for the report, I also just ran into the same thing.
It's probably instroduced by 89e73afc3f540 ("ARM: dts: marvell:
align SPI NOR node name with dtschema"), but I don't know why
there was no warning before.

Added the fixup patch now.

    Arnd

---
commit 7dc3be1745d05c1ed7d385487238ec06a07f4f29
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Jun 22 10:14:02 2023 +0200

    ARM: mvebu: fix unit address on armada-390-db flash
    
    The unit address needs to be changed to match the reg property:
    
    arch/arm/boot/dts/marvell/armada-390-db.dts:84.10-106.4: Warning (spi_bus_reg): /soc/spi@10680/flash@1: SPI bus unit address format error, expected "0"
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/arch/arm/boot/dts/marvell/armada-390-db.dts b/arch/arm/boot/dts/marvell/armada-390-db.dts
index 792d0a0184e82..20f518dbac971 100644
--- a/arch/arm/boot/dts/marvell/armada-390-db.dts
+++ b/arch/arm/boot/dts/marvell/armada-390-db.dts
@@ -81,7 +81,7 @@ &spi1 {
 	pinctrl-0 = <&spi1_pins>;
 	pinctrl-names = "default";
 
-	flash@1 {
+	flash@0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "n25q128a13",

  reply	other threads:[~2023-06-22  8:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  0:48 linux-next: build warning after merge of the arm-soc tree Stephen Rothwell
2023-06-22  8:19 ` Arnd Bergmann [this message]
2023-06-22  8:26   ` Krzysztof Kozlowski
2023-06-22 13:55   ` Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2021-12-22 21:59 Stephen Rothwell
2021-12-22 23:22 ` Arnd Bergmann
2021-12-22 23:58   ` Florian Fainelli
2021-12-23  8:50     ` Arınç ÜNAL
2021-12-23 18:18       ` Florian Fainelli
2021-10-25 23:39 Stephen Rothwell
2021-10-26  6:15 ` Joel Stanley
2022-01-20  3:22   ` Stephen Rothwell
2022-01-20  6:03     ` ChiaWei Wang
2021-04-06  0:45 Stephen Rothwell
2021-04-06  6:34 ` Krzysztof Kozlowski
2019-08-15 23:25 Stephen Rothwell
2019-08-15 23:23 Stephen Rothwell
2019-04-29 23:28 Stephen Rothwell
2019-05-03  6:49 ` Linus Walleij
2019-05-03 12:57   ` Arnd Bergmann
2014-01-19 23:39 Stephen Rothwell
2012-03-19  7:39 Stephen Rothwell
2012-03-19  9:40 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afeb9fad-0d3b-48ac-82da-218dcd8010e7@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).