From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Dan Murphy <dmurphy@ti.com>, Pavel Machek <pavel@ucw.cz>,
broonie@kernel.org, lgirdwood@gmail.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver
Date: Wed, 29 May 2019 22:50:32 +0200 [thread overview]
Message-ID: <afff7c24-bb68-e9dc-295e-4449f9729cc9@gmail.com> (raw)
In-Reply-To: <20190529135821.GK4574@dell>
On 5/29/19 3:58 PM, Lee Jones wrote:
> On Fri, 24 May 2019, Jacek Anaszewski wrote:
>
>> Hi,
>>
>> On 5/23/19 9:09 PM, Dan Murphy wrote:
>>> Pavel
>>>
>>> Thanks for the review
>>>
>>> On 5/23/19 7:50 AM, Pavel Machek wrote:
>>>> Hi!
>>>>
>>>>> +++ b/drivers/leds/leds-lm36274.c
>>>>
>>>>> +static int lm36274_parse_dt(struct lm36274 *lm36274_data)
>>>>> +{
>>>>> + struct fwnode_handle *child = NULL;
>>>>> + char label[LED_MAX_NAME_SIZE];
>>>>> + struct device *dev = &lm36274_data->pdev->dev;
>>>>> + const char *name;
>>>>> + int child_cnt;
>>>>> + int ret = -EINVAL;
>>>>> +
>>>>> + /* There should only be 1 node */
>>>>> + child_cnt = device_get_child_node_count(dev);
>>>>> + if (child_cnt != 1)
>>>>> + return ret;
>>>>
>>>> I'd do explicit "return -EINVAL" here.
>>>>
>>>
>>> ACK
>>>
>>>>> +static int lm36274_probe(struct platform_device *pdev)
>>>>> +{
>>>>> + struct ti_lmu *lmu = dev_get_drvdata(pdev->dev.parent);
>>>>> + struct lm36274 *lm36274_data;
>>>>> + int ret;
>>>>> +
>>>>> + lm36274_data = devm_kzalloc(&pdev->dev, sizeof(*lm36274_data),
>>>>> + GFP_KERNEL);
>>>>> + if (!lm36274_data) {
>>>>> + ret = -ENOMEM;
>>>>> + return ret;
>>>>> + }
>>>>
>>>> And certainly do "return -ENOMEM" explicitly here.
>>>>
>>>
>>> ACK
>>>
>>>> Acked-by: Pavel Machek <pavel@ucw.cz>
>>
>> I've done all amendments requested by Pavel and updated branch
>> ib-leds-mfd-regulator on linux-leds.git, but in the same time
>
> What do you mean by updated? You cannot update an 'ib' (immutable
> branch). Immutable means that it cannot change, by definition.
We have already talked about that. Nobody has pulled so the branch
could have been safely updated.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-05-29 20:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 19:27 [PATCH v4 0/6] LM36274 Introduction Dan Murphy
2019-05-22 19:27 ` [RESEND PATCH v4 1/6] regulator: lm363x: Make the gpio register enable flexible Dan Murphy
2019-05-22 21:22 ` Pavel Machek
2019-05-23 13:03 ` Mark Brown
2019-05-23 13:50 ` Dan Murphy
2019-05-26 12:48 ` Mark Brown
2019-05-29 11:51 ` Dan Murphy
2019-05-29 15:10 ` Mark Brown
2019-05-29 20:47 ` Dan Murphy
2019-05-30 15:26 ` Mark Brown
2019-06-04 15:14 ` Dan Murphy
2019-06-04 15:33 ` Mark Brown
2019-05-22 19:27 ` [RESEND PATCH v4 2/6] dt-bindings: mfd: Add lm36274 bindings to ti-lmu Dan Murphy
2019-05-22 21:22 ` Pavel Machek
2019-05-22 19:27 ` [RESEND PATCH v4 3/6] mfd: ti-lmu: Add LM36274 support to the ti-lmu Dan Murphy
2019-05-23 8:09 ` Pavel Machek
2019-05-22 19:27 ` [RESEND PATCH v4 4/6] regulator: lm363x: Add support for LM36274 Dan Murphy
2019-05-23 8:12 ` Pavel Machek
2019-05-23 13:04 ` Mark Brown
2019-05-22 19:27 ` [RESEND PATCH v4 5/6] dt-bindings: leds: Add LED bindings for the LM36274 Dan Murphy
2019-05-23 12:43 ` Pavel Machek
2019-05-22 19:27 ` [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver Dan Murphy
2019-05-23 12:50 ` Pavel Machek
2019-05-23 19:09 ` Dan Murphy
2019-05-24 20:51 ` Jacek Anaszewski
2019-05-29 13:58 ` Lee Jones
2019-05-29 20:50 ` Jacek Anaszewski [this message]
2019-05-30 7:38 ` Lee Jones
2019-05-30 19:58 ` Jacek Anaszewski
2019-05-31 6:23 ` Lee Jones
2019-05-31 19:44 ` Jacek Anaszewski
2019-05-31 21:07 ` Dan Murphy
2019-05-31 21:57 ` Jacek Anaszewski
2019-05-31 22:41 ` Dan Murphy
2019-06-01 13:55 ` Jacek Anaszewski
2019-05-22 19:37 ` [PATCH v4 0/6] LM36274 Introduction Jacek Anaszewski
2019-05-22 19:39 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afff7c24-bb68-e9dc-295e-4449f9729cc9@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).