From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: Mike Isely <isely@pobox.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oliver@neukum.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE)]
Date: Mon, 20 Oct 2008 12:33:02 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0810201231020.6072@p34.internal.lan> (raw)
In-Reply-To: <Pine.LNX.4.64.0810201119250.12643@cnc.isely.net>
On Mon, 20 Oct 2008, Mike Isely wrote:
>
> There's already a patch coming up through v4l-dvb that should remove the
> need for the reset completely for the pvrusb2 driver. The reset had
> been there as "chicken soup" previously - it didn't hurt but its
> utility wasn't really that great at the time. Now that it is hurting,
> I just removed it.
>
> -Mike
>
Should I wait for the patch coming up through v4l-dvb or test Alan's patch?
2.6.27.2 has quite a few issues:
1. xfs is broken w/barrier (there is a patch for this)
2. usb hangs (patch below)
3. abit-guru (comsetic issue only, doesn't find mobo) (there is a patch
for this now as well)
So I am sticking with 2.6.26.5 right now, let me know if you need me
to test Alan's patch to see if it fixes the issue.
Justin.
>>
>> Index: usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c
>> ===================================================================
>> --- usb-2.6.orig/drivers/media/video/pvrusb2/pvrusb2-main.c
>> +++ usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c
>> @@ -68,6 +68,16 @@ static void pvr_setup_attach(struct pvr2
>> #endif /* CONFIG_VIDEO_PVRUSB2_SYSFS */
>> }
>>
>> +static int pvr_pre_reset(struct usb_interface *intf)
>> +{
>> + return 0;
>> +}
>> +
>> +static int pvr_post_reset(struct usb_interface *intf)
>> +{
>> + return 0;
>> +}
>> +
>> static int pvr_probe(struct usb_interface *intf,
>> const struct usb_device_id *devid)
>> {
>> @@ -109,7 +119,9 @@ static struct usb_driver pvr_driver = {
>> .name = "pvrusb2",
>> .id_table = pvr2_device_table,
>> .probe = pvr_probe,
>> - .disconnect = pvr_disconnect
>> + .disconnect = pvr_disconnect,
>> + .pre_reset = pvr_pre_reset,
>> + .post_reset = pvr_post_reset,
>> };
>>
>> /*
next prev parent reply other threads:[~2008-10-20 16:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 11:26 Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE) Justin Piszcz
2008-10-19 11:28 ` Justin Piszcz
2008-10-19 15:34 ` Oliver Neukum
2008-10-19 16:51 ` Justin Piszcz
2008-10-20 14:02 ` Alan Stern
2008-10-20 15:21 ` Justin Piszcz
2008-10-20 16:17 ` Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE)] Alan Stern
2008-10-20 16:21 ` Mike Isely
2008-10-20 16:33 ` Justin Piszcz [this message]
2008-10-20 16:50 ` Mike Isely
2008-10-20 17:03 ` Justin Piszcz
2008-10-20 17:16 ` Alan Stern
2008-10-20 16:37 ` Mike Isely
2008-10-20 17:29 ` Greg KH
2008-10-20 18:01 ` Michael Krufky
2008-10-23 16:27 ` Mike Isely
2008-10-23 19:15 ` Greg KH
2008-10-23 19:54 ` Mike Isely
2008-10-23 22:04 ` Michael Krufky
2008-10-23 22:11 ` Justin Piszcz
2008-10-24 5:43 ` Mike Isely
2008-10-24 15:29 ` Michael Krufky
2008-10-24 21:30 ` Greg KH
2008-10-19 15:34 ` Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE) Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0810201231020.6072@p34.internal.lan \
--to=jpiszcz@lucidpixels.com \
--cc=isely@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).