From: Christoph Lameter <cl@linux-foundation.org>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: linux-mm@kvack.org, Matt Mackall <mpm@selenic.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] slab: initialize unused alien cache entry as NULL at alloc_alien_cache().
Date: Mon, 4 Jan 2010 11:27:07 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1001041126340.7191@router.home> (raw)
In-Reply-To: <4B31E9C3.6010109@linux.intel.com>
On Wed, 23 Dec 2009, Haicheng Li wrote:
> @@ -966,18 +966,16 @@ static void *alternate_node_alloc(struct kmem_cache *,
> gfp_t);
> static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp)
> {
> struct array_cache **ac_ptr;
> - int memsize = sizeof(void *) * nr_node_ids;
> + int memsize = sizeof(void *) * MAX_NUMNODES;
> int i;
Remove this change and I will ack the patch.
prev parent reply other threads:[~2010-01-04 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 12:38 [PATCH] slab: initialize unused alien cache entry as NULL at alloc_alien_cache() Haicheng Li
2009-12-22 12:40 ` Andi Kleen
2009-12-22 15:47 ` Christoph Lameter
2009-12-23 6:52 ` Haicheng Li
2009-12-23 10:10 ` Eric Dumazet
2009-12-23 10:23 ` Andi Kleen
2009-12-23 11:23 ` Haicheng Li
2010-01-04 17:26 ` Christoph Lameter
2009-12-22 22:38 ` Matt Mackall
2009-12-23 9:58 ` [PATCH v2] " Haicheng Li
2010-01-04 17:27 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1001041126340.7191@router.home \
--to=cl@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).