linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Pantelis Antoniou <pantelis.antoniou@gmail.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	torvalds@linux-foundation.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	tony@atomide.com, linux-arm-kernel@lists.infradead.org,
	mporter@ti.com
Subject: Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified
Date: Mon, 22 Aug 2011 17:26:33 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1108221723010.10315@utopia.booyaka.com> (raw)
In-Reply-To: <C5991460-2092-4E65-99EE-091F8DAA0AC3@gmail.com>

On Thu, 18 Aug 2011, Pantelis Antoniou wrote:

> Let me report that with this change Beagle board fails to boot,
> hangs right on rootfs mount.

Confirmed here.

Commit f3637a5f2e2eb391ff5757bc83fb5de8f9726464 ("irq: Always set 
IRQF_ONESHOT if no primary handler is specified"), merged as part of 
v3.1-rc3, won't boot into userspace via MMC on either OMAP4 Panda or 
OMAP3530 BeagleBoard.  v3.1-rc2 works.


- Paul

> Users of BB should revert this until the offending driver(s) are fixed.
> 
> Regards
> 
> -- Pantelis
> 
> On Jul 7, 2011, at 11:32 PM, Sebastian Andrzej Siewior wrote:
> 
> > If no primary handler is specified then a default one is assigned which
> > always returns IRQ_WAKE_THREAD. This handler requires the IRQF_ONESHOT
> > flag on LEVEL / EIO typed irqs because the source of interrupt is not
> > disabled.
> > Since it is required for those users and there is no difference for others
> > it makes sense to add this flag unconditionally.
> > 
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > A quick grep shows that drivers/staging/iio/adc/ad7816.c is the only
> > driver in tree doing it wrong i.e. request_threaded_irq with
> > IRQF_TRIGGER_{LOW|HIGH} but without ONEHOST.
> > 
> > There are 59 users in tree which request an edge typed interrupt. 24 of
> > them specify the ONEHOST flag the others don't. Both variants are valid
> > and identical but a consistent behavior would be nice.
> > 
> > There is a total of 134 users and 87 specify the irq type directly. For
> > the remaining 47 the type depends on initial configuration of the irq chip
> > or it might be specified via the device tree, dunno. 
> > Should that patch be accepted I suggest to remove the ONESHOT flag from
> > every request_th.* which uses NULL as the primary handler so we have a
> > consistent behavior here.
> > 
> > kernel/irq/manage.c |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> > index 0a7840ae..3f9cd47 100644
> > --- a/kernel/irq/manage.c
> > +++ b/kernel/irq/manage.c
> > @@ -1322,6 +1322,7 @@ int request_threaded_irq(unsigned int irq, irq_handler_t handler,
> > 		if (!thread_fn)
> > 			return -EINVAL;
> > 		handler = irq_default_primary_handler;
> > +		irqflags |= IRQF_ONESHOT;
> > 	}
> > 
> > 	action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);
> > -- 
> > 1.7.4.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

      parent reply	other threads:[~2011-08-22 23:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 20:32 [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified Sebastian Andrzej Siewior
2011-07-28  9:39 ` [tip:irq/urgent] irq: Always " tip-bot for Sebastian Andrzej Siewior
2011-08-18 17:01 ` [PATCH] irq: always " Pantelis Antoniou
2011-08-18 17:22   ` Sebastian Andrzej Siewior
2011-08-18 21:34     ` Felipe Balbi
2011-08-19  7:25       ` Sebastian Andrzej Siewior
2011-08-19 10:13         ` Felipe Balbi
2011-08-22 23:45       ` Paul Walmsley
2011-08-23  5:10         ` [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified) Paul Walmsley
2011-08-23  8:14           ` Sebastian Andrzej Siewior
2011-08-23  8:57           ` Alan Cox
2011-08-23 16:13             ` Linus Torvalds
2011-08-23 16:46               ` Thomas Gleixner
2011-08-23  9:12           ` Felipe Balbi
2011-08-23 17:21             ` Paul Walmsley
2011-08-23  9:09         ` [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified Felipe Balbi
2011-08-22 23:26   ` Paul Walmsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1108221723010.10315@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=pantelis.antoniou@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).