From: Christoph Lameter <cl@linux.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
"Alex,Shi" <alex.shi@intel.com>,
Shaohua Li <shaohua.li@intel.com>, Matt Mackall <mpm@selenic.com>,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [PATCH] slub: prefetch next freelist pointer in slab_alloc()
Date: Mon, 30 Jan 2012 15:53:51 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1201301549240.3895@router.home> (raw)
In-Reply-To: <CAMuHMdW-RbD-uxpOGmhv0LCsHLG-2Q0LvSRrB0cdM2efGRAYnw@mail.gmail.com>
On Mon, 30 Jan 2012, Geert Uytterhoeven wrote:
> On Tue, Jan 24, 2012 at 20:54, Pekka Enberg <penberg@kernel.org> wrote:
> > On Fri, 16 Dec 2011, Eric Dumazet wrote:
> >>> Recycling a page is a problem, since freelist link chain is hot on
> >>> cpu(s) which freed objects, and possibly very cold on cpu currently
> >>> owning slab.
> >
> > On Fri, 16 Dec 2011, Christoph Lameter wrote:
> >> Good idea. How do the tcp benchmarks look after this?
> >>
> >> Looks sane.
> >>
> >> Acked-by: Christoph Lameter <cl@linux.com>
> >
> > Applied, thanks!
>
> m68k/allmodconfig at http://kisskb.ellerman.id.au/kisskb/buildresult/5527349/
>
> mm/slub.c:274: error: implicit declaration of function 'prefetch'
>
> Sorry, didn't notice it earlier due to other build breakage in -next.
Does this fix it?
Subject: slub: include include for prefetch
Otherwise m68k breaks.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Christoph Lameter <cl@linux.com>
---
mm/slub.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2012-01-13 10:04:06.000000000 -0600
+++ linux-2.6/mm/slub.c 2012-01-30 15:51:55.000000000 -0600
@@ -29,6 +29,7 @@
#include <linux/math64.h>
#include <linux/fault-inject.h>
#include <linux/stacktrace.h>
+#include <linux/prefetch.h>
#include <trace/events/kmem.h>
next prev parent reply other threads:[~2012-01-30 21:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 15:25 [PATCH] slub: prefetch next freelist pointer in slab_alloc() Eric Dumazet
2011-12-16 16:31 ` Christoph Lameter
2011-12-16 17:18 ` Eric Dumazet
2011-12-17 22:56 ` Eric Dumazet
2012-01-24 19:54 ` Pekka Enberg
2012-01-30 21:32 ` Geert Uytterhoeven
2012-01-30 21:53 ` Christoph Lameter [this message]
2012-02-09 20:00 ` Geert Uytterhoeven
2011-12-18 22:47 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1201301549240.3895@router.home \
--to=cl@linux.com \
--cc=alex.shi@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).