From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen pvhvm: do not remap pirqs onto evtchns if !xen_have_vector_callback
Date: Tue, 31 Jan 2012 16:40:26 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1201311636380.3196@kaball-desktop> (raw)
In-Reply-To: <20120131162759.GA18248@phenom.dumpdata.com>
On Tue, 31 Jan 2012, Konrad Rzeszutek Wilk wrote:
> On Mon, Jan 30, 2012 at 02:31:46PM +0000, Stefano Stabellini wrote:
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> So the xen_have_vector_callback looks to be only set by
>
> 1398 if (xen_feature(XENFEAT_hvm_callback_vector))
> 1399 xen_have_vector_callback = 1;
>
> So could this be just done via a check for that instead?
>
Sure, but I don't think it would be better: using
xen_have_vector_callback is more consistent and give us the flexibility
of allowing users to manually override it in the future.
next prev parent reply other threads:[~2012-01-31 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 14:31 [PATCH] xen pvhvm: do not remap pirqs onto evtchns if !xen_have_vector_callback Stefano Stabellini
2012-01-31 16:27 ` Konrad Rzeszutek Wilk
2012-01-31 16:40 ` Stefano Stabellini [this message]
2012-02-01 1:08 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-02-01 11:09 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1201311636380.3196@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).