From: David Rientjes <rientjes@google.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>,
linux-wireless@vger.kernel.org, johannes.berg@intel.com,
wey-yi.w.guy@intel.com, ilw@linux.intel.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: iwl3945: order 5 allocation during ifconfig up; vm problem?
Date: Wed, 3 Oct 2012 11:07:13 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1210031104120.29765@chino.kir.corp.google.com> (raw)
In-Reply-To: <20121003113659.GD2259@redhat.com>
On Wed, 3 Oct 2012, Stanislaw Gruszka wrote:
> So, can this problem be solved like on below patch, or I should rather
> split firmware loading into chunks similar like was already iwlwifi did?
>
> diff --git a/drivers/net/wireless/iwlegacy/common.h b/drivers/net/wireless/iwlegacy/common.h
> index 5f50177..1b58222 100644
> --- a/drivers/net/wireless/iwlegacy/common.h
> +++ b/drivers/net/wireless/iwlegacy/common.h
> @@ -2247,7 +2247,7 @@ il_alloc_fw_desc(struct pci_dev *pci_dev, struct fw_desc *desc)
>
> desc->v_addr =
> dma_alloc_coherent(&pci_dev->dev, desc->len, &desc->p_addr,
> - GFP_KERNEL);
> + GFP_KERNEL | __GFP_REPEAT);
> return (desc->v_addr != NULL) ? 0 : -ENOMEM;
> }
>
I think this will certainly make memory compaction more aggressive by
avoiding the logic to defer calling compaction in the page allocator, but
because we lack lumpy reclaim this still has a higher probability of
failing than it had in the past because it will fail if 128KB of memory is
reclaimed that may not happen to be contiguous for an order-5 allocation
to succeed.
next prev parent reply other threads:[~2012-10-03 18:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 21:32 iwl3945: order 5 allocation during ifconfig up; vm problem? Pavel Machek
2012-09-09 22:40 ` David Rientjes
2012-09-10 11:11 ` Pavel Machek
2012-09-11 23:25 ` Andrew Morton
2012-09-12 5:16 ` Eric Dumazet
2012-09-12 5:57 ` Marc MERLIN
2012-09-12 6:54 ` Johannes Berg
2012-09-24 9:03 ` Dan Carpenter
2012-09-24 9:14 ` Johannes Berg
2012-09-12 9:22 ` Stanislaw Gruszka
2012-09-12 10:18 ` Mel Gorman
2012-10-03 11:37 ` Stanislaw Gruszka
2012-10-03 18:07 ` David Rientjes [this message]
2012-10-05 8:37 ` Stanislaw Gruszka
2012-10-06 12:08 ` Pavel Machek
2012-10-08 15:38 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210031104120.29765@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=pavel@ucw.cz \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).