From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Joe Perches <joe@perches.com>, Michal Marek <mmarek@suse.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Anton Blanchard <anton@au1.ibm.com>,
Ian Munsie <imunsie@au1.ibm.com>,
Michael Neuling <mikey@neuling.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
Olof Johansson <olof@lixom.net>
Subject: Re: Build failure: -Wno-unused-const-variable DNE on old GCC
Date: Sat, 30 Jan 2016 14:20:24 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1601301413370.5958@tp.orcam.me.uk> (raw)
In-Reply-To: <20160107201826.GA120952@google.com>
On Thu, 7 Jan 2016, Brian Norris wrote:
> > Perhaps most uses of -Werror without some CONFIG_<FOO> guard
> > should be removed or replaced by some other mechanism.
>
> +1000. I'd personally like to see all one-off uses of -Werror removed.
>
> > $ git grep -E "=\s*\-Werror" | grep -v CONFIG
> > [...]
> > arch/alpha/lib/Makefile:ccflags-y := -Werror
> > arch/alpha/mm/Makefile:ccflags-y := -Werror
> > arch/alpha/oprofile/Makefile:ccflags-y := -Werror -Wno-sign-compare
> > arch/metag/oprofile/Makefile:ccflags-y += -Werror
> > arch/mips/Kbuild:subdir-ccflags-y := -Werror
>
> ^^ I always patch this one out when build-testing MIPS, since I like to
> turn up warning levels (e.g., W=1), but not kill the build entirely.
The MIPS port switched on -Werror years ago, because people submitted
awful code and couldn't be bothered unless the build crashed. You're
welcome to patch your own tree, however I maintain it was a very good
decision, and TBH I think -Werror should be on globally.
Maciej
next prev parent reply other threads:[~2016-01-30 14:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:54 Build failure: -Wno-unused-const-variable DNE on old GCC Brian Norris
2016-01-07 19:37 ` Joe Perches
2016-01-07 19:44 ` Michal Marek
2016-01-07 19:57 ` Joe Perches
2016-01-07 20:18 ` Brian Norris
2016-01-07 20:38 ` [PATCH] misc: cxl: fix build for GCC 4.6.x Brian Norris
2016-01-08 2:12 ` Michael Ellerman
2016-01-30 14:20 ` Maciej W. Rozycki [this message]
2016-01-30 17:37 ` Build failure: -Wno-unused-const-variable DNE on old GCC Joe Perches
2016-01-07 20:25 ` Arnd Bergmann
2016-01-07 22:51 ` Daniel Axtens
2016-01-07 23:02 ` Brian Norris
2016-01-08 1:31 ` Ian Munsie
2016-01-08 2:07 ` Brian Norris
2016-01-08 2:16 ` Michael Ellerman
2016-01-08 10:14 ` David Laight
2016-01-08 1:33 ` Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1601301413370.5958@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=anton@au1.ibm.com \
--cc=computersforpeace@gmail.com \
--cc=imunsie@au1.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mmarek@suse.com \
--cc=mpe@ellerman.id.au \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).