From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbcDRSJ5 (ORCPT ); Mon, 18 Apr 2016 14:09:57 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:31024 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbcDRSJ4 (ORCPT ); Mon, 18 Apr 2016 14:09:56 -0400 Date: Mon, 18 Apr 2016 19:09:42 +0100 From: "Maciej W. Rozycki" To: Ralf Baechle , Matthew Fortune CC: "Maciej W. Rozycki" , kbuild test robot , Paul Burton , , Subject: Re: {standard input}:136: Error: number (0x9000000080000000) larger than 32 bits In-Reply-To: <20160418155440.GC24051@linux-mips.org> Message-ID: References: <201604170836.kTyP1sCY%fengguang.wu@intel.com> <20160417011926.GA4014@linux-mips.org> <20160418133449.GB24051@linux-mips.org> <20160418155440.GC24051@linux-mips.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [10.20.78.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Apr 2016, Ralf Baechle wrote: > I extracted a rather simple test case: > > $ echo >> testcase .s << EOF > .set mips3 > dli $2, 0x9000000080000000 > EOF > $ mips-linux-as -mips3 -march=r4600 -o testcase.o testcase.s > testcase.s: Assembler messages: > testcase.s:2: Error: number (0x9000000080000000) larger than 32 bits > $ mips-linux-as -mips4 -march=vr5000 -o testcase.o testcase.s > $ Ah, and if you use `.set mips4' instead, then the symptoms reverse. The thing is that to match some software's (such as ours) requirements an ISA override -- as a side effect -- relaxes ABI restrictions on certain operations. E.g. the DLI macro and its 64-bit immediate argument are not valid in the o32 ABI. When no actual override happens, such as with `-march=r4600' which already implies `mips3' for the ISA, the side effect is lost: /* The use of .set [arch|cpu]= historically 'fixes' the width of gp and fp registers based on what is supported by the arch/cpu. */ if (mips_opts.isa != prev_isa) > I can trigger the error message with vanilla 2.25 and 2.26 but not 2.24. The regression has come with: commit 919731affbef19fcad8dddb0a595bb05755cb345 Author: mfortune Date: Tue May 20 13:28:20 2014 +0100 Add MIPS .module directive -- previously the side effect was unconditional, even if no ISA change resulted. Matthew, this functional change was not mentioned in the review: -- what was the rationale behind it? Do you expect any issues if we revert to old semantics? Maciej