From: Christian Kujau <lists@nerdbynature.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: error: 'cpus_in_crash' defined but not used
Date: Tue, 17 Jan 2012 21:13:05 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.01.1201172104410.2895@trent.utfs.org> (raw)
In-Reply-To: <alpine.DEB.2.01.1201172006310.2895@trent.utfs.org>
On Tue, 17 Jan 2012 at 20:13, Christian Kujau wrote:
>
> compiling today's git (mainline, a25a2b8) on powerpc32 gives:
>
> CC arch/powerpc/kernel/crash.o
> cc1: warnings being treated as errors
> /usr/local/src/linux-2.6-git/arch/powerpc/kernel/crash.c:49: error:
> ‘cpus_in_crash’ defined but not used
> make[2]: *** [arch/powerpc/kernel/crash.o] Error 1
> make[1]: *** [arch/powerpc/kernel] Error 2
> make: *** [sub-make] Error 2
I could not find cpus_in_crash anywhere in the sourcetree, except for
arch/powerpc/kernel/crash.c. Moving the definition into the CONFIG_SMP
ifdef helps on my UP system, of course - not sure about other machines
though:
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
index 28be345..abef751 100644
--- a/arch/powerpc/kernel/crash.c
+++ b/arch/powerpc/kernel/crash.c
@@ -46,7 +46,6 @@
/* This keeps a track of which one is the crashing cpu. */
int crashing_cpu = -1;
-static atomic_t cpus_in_crash;
static int time_to_dump;
#define CRASH_HANDLER_MAX 3
@@ -66,6 +65,7 @@ static int handle_fault(struct pt_regs *regs)
#ifdef CONFIG_SMP
+static atomic_t cpus_in_crash;
void crash_ipi_callback(struct pt_regs *regs)
{
static cpumask_t cpus_state_saved = CPU_MASK_NONE;
Christian.
--
BOFH excuse #272:
Netscape has crashed
next prev parent reply other threads:[~2012-01-18 5:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 4:13 error: ‘cpus_in_crash’ defined but not used Christian Kujau
2012-01-18 5:13 ` Christian Kujau [this message]
2012-01-21 0:45 ` error: 'cpus_in_crash' " Christian Kujau
2012-01-24 23:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.01.1201172104410.2895@trent.utfs.org \
--to=lists@nerdbynature.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).