From: Thomas Gleixner <tglx@linutronix.de>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xen.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped
Date: Fri, 21 Jun 2013 09:57:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1306210953480.4013@ionos.tec.linutronix.de> (raw)
In-Reply-To: <1371755792-25962-3-git-send-email-david.vrabel@citrix.com>
On Thu, 20 Jun 2013, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> The high resolution timer code gets notified of step changes to the
> system time with clock_was_set() or clock_was_set_delayed() calls. If
> other parts of the kernel require similar notification there is no
> clear place to hook into.
You fail to explain why any other part of the kernel requires a
notification.
We went great length to confine timekeeping inside the core code and
now you add random notifiers along with totally ugly tasklet
constructs. What for?
Without a reasonable explanation of the problem you are trying to
solve this is going nowhere near the tree.
Thanks,
tglx
next prev parent reply other threads:[~2013-06-21 7:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 19:16 [PATCHv5 0/4] xen: maintain an accurate persistent clock in more cases David Vrabel
2013-06-20 19:16 ` [PATCH 1/4] hrtimers: provide a hrtimers_late_resume() call David Vrabel
2013-06-21 7:53 ` Thomas Gleixner
2013-06-21 12:32 ` David Vrabel
2013-06-21 14:32 ` Thomas Gleixner
2013-06-21 17:30 ` David Vrabel
2013-06-21 21:24 ` Thomas Gleixner
2013-06-20 19:16 ` [PATCH 2/4] time: add a notifier chain for when the system time is stepped David Vrabel
2013-06-21 7:57 ` Thomas Gleixner [this message]
2013-06-21 12:41 ` David Vrabel
2013-06-21 23:06 ` Thomas Gleixner
2013-06-24 10:51 ` David Vrabel
2013-06-24 16:30 ` Thomas Gleixner
2013-06-24 17:00 ` David Vrabel
2013-06-24 17:50 ` John Stultz
2013-06-24 19:55 ` Thomas Gleixner
2013-06-21 16:22 ` John Stultz
2013-06-20 19:16 ` [PATCH 3/4] x86/xen: sync the wallclock " David Vrabel
2013-06-20 19:16 ` [PATCH 4/4] x86/xen: sync the CMOS RTC as well as the Xen wallclock David Vrabel
2013-06-20 20:03 ` [PATCHv5 0/4] xen: maintain an accurate persistent clock in more cases John Stultz
2013-06-21 18:31 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2013-06-19 15:25 [PATCHv4 " David Vrabel
2013-06-19 15:25 ` [PATCH 2/4] time: add a notifier chain for when the system time is stepped David Vrabel
2013-06-19 16:52 ` John Stultz
2013-06-19 17:13 ` Konrad Rzeszutek Wilk
2013-06-19 17:38 ` John Stultz
2013-06-20 10:50 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1306210953480.4013@ionos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=david.vrabel@citrix.com \
--cc=john.stultz@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).