From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbbH1Hks (ORCPT ); Fri, 28 Aug 2015 03:40:48 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:45225 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbbH1Hkp (ORCPT ); Fri, 28 Aug 2015 03:40:45 -0400 Date: Fri, 28 Aug 2015 09:40:41 +0200 From: Ricard Wanderlof X-X-Sender: ricardw@lnxricardw1.se.axis.com To: Stephen Rothwell CC: Mark Brown , Liam Girdwood , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: linux-next: build failure after merge of the sound-asoc tree In-Reply-To: <20150828115041.037554b4@canb.auug.org.au> Message-ID: References: <20150828115041.037554b4@canb.auug.org.au> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Aug 2015, Stephen Rothwell wrote: > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from sound/soc/codecs/ics43432.c:12:0: > sound/soc/codecs/ics43432.c:60:25: error: 'ics43432_dt_ids' undeclared here (not in a function) > MODULE_DEVICE_TABLE(of, ics43432_dt_ids); > ^ > include/linux/module.h:223:21: note: in definition of macro 'MODULE_DEVICE_TABLE' > extern const typeof(name) __mod_##type##__##name##_device_table \ > ^ > include/linux/module.h:223:27: error: '__mod_of__ics43432_dt_ids_device_table' aliased to undefined symbol 'ics43432_dt_ids' > extern const typeof(name) __mod_##type##__##name##_device_table \ > ^ > sound/soc/codecs/ics43432.c:60:1: note: in expansion of macro 'MODULE_DEVICE_TABLE' > MODULE_DEVICE_TABLE(of, ics43432_dt_ids); > ^ > > Caused by commit > > 3b7ce99748f0 ("ASoC: ics43432: Add codec driver for InvenSense ICS-43432") > > Not really build tested with CONFIG_OF set, right? :-( Well, actually, yes. In fact the exact same construct is used by a handful of other codec drivers which apparently don't fail. I'm suspecting something slightly more convoluted like a missing #include . > I have reverted that commit for today. Ok. I'll get to work on this ASAP. /Ricard -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Sweden www.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30