From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbbLNHRj (ORCPT ); Mon, 14 Dec 2015 02:17:39 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:39504 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbbLNHRi (ORCPT ); Mon, 14 Dec 2015 02:17:38 -0500 X-IronPort-AV: E=Sophos;i="5.20,426,1444687200"; d="scan'208";a="191894654" Date: Mon, 14 Dec 2015 08:17:35 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: Sergey Senozhatsky , LKML , Minchan Kim , Nitin Gupta , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection In-Reply-To: <566E6895.5050603@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <566B13C1.50907@users.sourceforge.net> <566B14DA.1080709@users.sourceforge.net> <20151214002702.GA718@swordfish> <566E6895.5050603@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I suggest to make the affected exception handling a bit more efficient. > Such source code fine-tuning has got a few special consequences. Exception handling is by definition exceptional, and thus its efficiency is rarely important. What is important is that it should be correct, and ideally clearly correct, so that someone can check its correctness easily. Optimizations, if they have any effect at all, typically make the correctness less obvious. julia