From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbcACQl1 (ORCPT ); Sun, 3 Jan 2016 11:41:27 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:2646 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbcACQlX (ORCPT ); Sun, 3 Jan 2016 11:41:23 -0500 X-IronPort-AV: E=Sophos;i="5.20,516,1444687200"; d="scan'208";a="195355354" Date: Sun, 3 Jan 2016 17:41:21 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: devel@driverdev.osuosl.org, Christopher Harrer , Greg Kroah-Hartman , Lior Dotan , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() In-Reply-To: <56894D2D.1010801@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 17:25:59 +0100 > > Replace explicit initialisation for two local variables at the beginning > by assignments. Why? julia > Signed-off-by: Markus Elfring > --- > drivers/staging/slicoss/slicoss.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > index b23a2d1..8fdcac8 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -2301,9 +2301,9 @@ static int slic_adapter_allocresources(struct adapter *adapter, > */ > static int slic_if_init(struct adapter *adapter, unsigned long *flags) > { > - struct sliccard *card = adapter->card; > + struct sliccard *card; > struct net_device *dev = adapter->netdev; > - __iomem struct slic_regs *slic_regs = adapter->slic_regs; > + __iomem struct slic_regs *slic_regs; > struct slic_shmem *pshmem; > int rc; > > @@ -2348,6 +2348,7 @@ static int slic_if_init(struct adapter *adapter, unsigned long *flags) > adapter->queues_initialized = 1; > } > > + slic_regs = adapter->slic_regs; > slic_reg32_write(&slic_regs->slic_icr, ICR_INT_OFF, FLUSH); > mdelay(1); > > @@ -2374,6 +2375,7 @@ static int slic_if_init(struct adapter *adapter, unsigned long *flags) > } > > adapter->state = ADAPT_UP; > + card = adapter->card; > if (!card->loadtimerset) { > setup_timer(&card->loadtimer, &slic_timer_load_check, > (ulong)card); > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >