From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
<linux-arm-kernel@lists.infradead.org>,
<ard.biesheuvel@linaro.org>, <stefano.stabellini@citrix.com>,
<david.vrabel@citrix.com>, <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>, <linux-efi@vger.kernel.org>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xen.org>,
<julien.grall@citrix.com>, <shannon.zhao@linaro.org>,
<peter.huangpeng@huawei.com>, <zhaoshenglong@huawei.com>
Subject: Re: [Xen-devel] [PATCH v2 08/16] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ
Date: Mon, 18 Jan 2016 12:46:43 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1601181244300.16178@kaball.uk.xensource.com> (raw)
In-Reply-To: <569CDDB7.9030103@citrix.com>
On Mon, 18 Jan 2016, Andrew Cooper wrote:
> On 18/01/16 12:38, Stefano Stabellini wrote:
> > On Fri, 15 Jan 2016, Shannon Zhao wrote:
> >> From: Shannon Zhao <shannon.zhao@linaro.org>
> >>
> >> Add a new delivery type:
> >> val[63:56] == 3: val[15:8] is flag: val[7:0] is a PPI.
> >> To the flag, bit 0 stands the interrupt mode is edge(1) or level(0) and
> >> bit 1 stands the interrupt polarity is active low(1) or high(0).
> >>
> >> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> >> ---
> >> include/xen/interface/hvm/params.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/include/xen/interface/hvm/params.h b/include/xen/interface/hvm/params.h
> >> index a6c7991..550688a 100644
> >> --- a/include/xen/interface/hvm/params.h
> >> +++ b/include/xen/interface/hvm/params.h
> >> @@ -34,6 +34,11 @@
> >> * Domain = val[47:32], Bus = val[31:16],
> >> * DevFn = val[15: 8], IntX = val[ 1: 0]
> >> * val[63:56] == 2: val[7:0] is a vector number.
> >> + * val[63:56] == 3: val[15:8] is flag of event-channel interrupt:
> >> + * bit 0: interrupt is edge(1) or level(0) triggered
> >> + * bit 1: interrupt is active low(1) or high(0)
> >> + * val[7:0] is PPI number used by event-channel.
> >> + * This is only used by ARM/ARM64.
> >> * If val == 0 then CPU0 event-channel notifications are not delivered.
> >> */
> >> #define HVM_PARAM_CALLBACK_IRQ 0
> > Andrew, I think that this patch is correct. Looking back at your
> > previous comment (http://marc.info/?l=devicetree&m=144804014214262&w=2),
> > is it possible that you were confused by enum callback_via_type, which
> > is internal to Xen and offset'ed by 1 compared to the described values
> > in xen/include/public/hvm/params.h?
> >
> > If not, and indeed somebody introduced one more field but failed to
> > document it, then I suggest she sends a patch to fix the issue as soon
> > as possible.
>
> I was indeed confused - the ABI is utterly mad.
All right. In that case, Shannon, you can add my
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> However, this change does need rebasing over c/s ca5c54b, which was the
> result of the original discussion.
c/s ca5c54b is for Xen, while this is a Linux patch (Linux has its own
set of Xen headers).
next prev parent reply other threads:[~2016-01-18 12:47 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 6:55 [PATCH v2 00/16] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-01-15 15:39 ` Stefano Stabellini
2016-01-18 10:32 ` Mark Rutland
2016-01-18 11:38 ` Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 02/16] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
2016-01-15 15:53 ` [Xen-devel] " Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 03/16] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
2016-01-15 17:08 ` [Xen-devel] " Stefano Stabellini
2016-01-18 5:08 ` Shannon Zhao
2016-01-19 14:59 ` Stefano Stabellini
2016-01-19 15:10 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 04/16] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
2016-01-15 17:21 ` Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 05/16] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 06/16] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
2016-01-15 17:39 ` [Xen-devel] " Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 07/16] Xen: ARM: Add support for mapping AMBA " Shannon Zhao
2016-01-18 11:58 ` [Xen-devel] " Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 08/16] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-01-18 12:38 ` [Xen-devel] " Stefano Stabellini
2016-01-18 12:42 ` Andrew Cooper
2016-01-18 12:46 ` Stefano Stabellini [this message]
2016-01-18 12:52 ` Andrew Cooper
2016-01-20 6:33 ` Shannon Zhao
2016-01-20 8:39 ` Andrew Cooper
2016-01-20 8:45 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 09/16] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
2016-01-18 14:38 ` [Xen-devel] " Stefano Stabellini
2016-01-19 8:21 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-01-18 14:59 ` [Xen-devel] " Stefano Stabellini
2016-01-19 8:36 ` Shannon Zhao
2016-01-19 12:14 ` Stefano Stabellini
2016-01-15 6:55 ` [PATCH v2 11/16] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-01-18 10:41 ` Mark Rutland
2016-01-18 15:07 ` Stefano Stabellini
2016-01-19 8:41 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-01-17 3:43 ` Rob Herring
2016-01-18 10:51 ` Mark Rutland
2016-01-18 17:34 ` Stefano Stabellini
2016-01-19 10:25 ` Shannon Zhao
2016-01-19 10:47 ` Mark Rutland
2016-01-19 12:23 ` Stefano Stabellini
2016-01-19 13:13 ` Mark Rutland
2016-01-19 13:18 ` Ard Biesheuvel
2016-01-19 13:43 ` Shannon Zhao
2016-01-19 14:11 ` Stefano Stabellini
2016-01-21 11:50 ` Mark Rutland
2016-01-15 6:55 ` [PATCH v2 13/16] ARM: XEN: Set EFI_PARAVIRT if Xen supports EFI Shannon Zhao
2016-01-18 10:57 ` Mark Rutland
2016-01-15 6:55 ` [PATCH v2 14/16] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
2016-01-18 11:03 ` Mark Rutland
2016-01-18 15:41 ` [Xen-devel] " Stefano Stabellini
2016-01-19 13:19 ` Shannon Zhao
2016-01-19 13:43 ` Mark Rutland
2016-01-19 13:46 ` Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 15/16] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-01-15 6:55 ` [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Shannon Zhao
2016-01-18 11:08 ` Mark Rutland
2016-01-18 17:45 ` Stefano Stabellini
2016-01-18 18:27 ` Mark Rutland
2016-01-19 12:03 ` Stefano Stabellini
2016-01-19 13:03 ` Mark Rutland
2016-01-19 13:31 ` Shannon Zhao
2016-01-19 14:20 ` Stefano Stabellini
2016-01-18 17:03 ` [Xen-devel] " Stefano Stabellini
2016-01-19 13:12 ` Shannon Zhao
2016-01-19 14:24 ` Stefano Stabellini
2016-01-22 3:58 ` Shannon Zhao
2016-01-22 10:57 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1601181244300.16178@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.vrabel@citrix.com \
--cc=devicetree@vger.kernel.org \
--cc=julien.grall@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).