From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbcDNGyf (ORCPT ); Thu, 14 Apr 2016 02:54:35 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:23806 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbcDNGye (ORCPT ); Thu, 14 Apr 2016 02:54:34 -0400 X-IronPort-AV: E=Sophos;i="5.24,483,1454972400"; d="scan'208";a="174234861" Date: Thu, 14 Apr 2016 08:54:30 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= cc: Boris Brezillon , linux-mtd@lists.infradead.org, Richard Weinberger , David Woodhouse , Brian Norris , open list , kbuild@01.org Subject: [PATCH] mtd: nand: omap2: fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-417385849-1460616872=:2001" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-417385849-1460616872=:2001 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Rafał Miłecki Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- It's minor point, but I think it would look a bit nicer, since one would see the important thing (is_write) first. omap2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -208,7 +208,7 @@ static int omap_prefetch_enable(int cs, */ val = ((cs << PREFETCH_CONFIG1_CS_SHIFT) | PREFETCH_FIFOTHRESHOLD(fifo_th) | ENABLE_PREFETCH | - (dma_mode << DMA_MPU_MODE_SHIFT) | (0x1 & is_write)); + (dma_mode << DMA_MPU_MODE_SHIFT) | (is_write & 0x1)); writel(val, info->reg.gpmc_prefetch_config1); /* Start the prefetch engine */ --8323328-417385849-1460616872=:2001--