From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644AbcDOHPy (ORCPT ); Fri, 15 Apr 2016 03:15:54 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11134 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbcDOHPw (ORCPT ); Fri, 15 Apr 2016 03:15:52 -0400 X-IronPort-AV: E=Sophos;i="5.24,486,1454972400"; d="scan'208";a="214266888" Date: Fri, 15 Apr 2016 09:15:49 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Dave Airlie cc: kbuild-all@01.org, Alex Deucher , =?ISO-8859-15?Q?Christian_K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Could be nice to put the thing being tested first. amdgpu_grph_object_id_helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_grph_object_id_helpers.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_grph_object_id_helpers.c @@ -169,11 +169,11 @@ struct graphics_object_id amdgpu_object_ struct graphics_object_id go_id = { 0 }; type = object_type_from_bios_object_id(bios_object_id); - if (OBJECT_TYPE_UNKNOWN == type) + if (type == OBJECT_TYPE_UNKNOWN) return go_id; enum_id = enum_id_from_bios_object_id(bios_object_id); - if (ENUM_ID_UNKNOWN == enum_id) + if (enum_id == ENUM_ID_UNKNOWN) return go_id; go_id = display_graphics_object_id_init(