From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbcEPGwE (ORCPT ); Mon, 16 May 2016 02:52:04 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51994 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbcEPGwD (ORCPT ); Mon, 16 May 2016 02:52:03 -0400 X-IronPort-AV: E=Sophos;i="5.24,626,1454972400"; d="scan'208";a="218391828" Date: Mon, 16 May 2016 08:51:59 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: SF Markus Elfring cc: Lee Jones , Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() In-Reply-To: <3c168185-ec2d-f1f7-fe70-8a230b884ed2@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <3c168185-ec2d-f1f7-fe70-8a230b884ed2@users.sourceforge.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 May 2016 19:20:28 +0200 > > The platform_device_put() function was called in one case by the > add_numbered_child() function during error handling even if the passed > variable "pdev" contained a null pointer. > > * Change an error message. Why? Is dev_err needed? Doesn't it already print out the device name? In any case, the only source of failure is failure of a kzalloc in platform_device_alloc, which means that a complete backtrace would be generated, so it is not clear that any message is needed at all. julia > > * Return directly in this case. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/twl-core.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index 831696e..dc34e69 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -623,9 +623,10 @@ add_numbered_child(unsigned mod_no, const char *name, int num, > > pdev = platform_device_alloc(name, num); > if (!pdev) { > - dev_dbg(&twl->client->dev, "can't alloc dev\n"); > - status = -ENOMEM; > - goto err; > + dev_err(&twl->client->dev, > + "Allocation failed for device: %s\n", > + name); > + return ERR_PTR(-ENOMEM); > } > > pdev->dev.parent = &twl->client->dev; > -- > 2.8.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >