From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753357AbcFLTQa (ORCPT <rfc822;w@1wt.eu>);
	Sun, 12 Jun 2016 15:16:30 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:59317 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751182AbcFLTQ3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 12 Jun 2016 15:16:29 -0400
X-IronPort-AV: E=Sophos;i="5.26,462,1459807200"; 
   d="scan'208";a="222127587"
Date: Sun, 12 Jun 2016 21:16:24 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: Deepa Dinamani <deepa.kernel@gmail.com>
cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags
In-Reply-To: <1465758279-16111-1-git-send-email-deepa.kernel@gmail.com>
Message-ID: <alpine.DEB.2.02.1606122113450.2180@localhost6.localdomain6>
References: <1465758279-16111-1-git-send-email-deepa.kernel@gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Sun, 12 Jun 2016, Deepa Dinamani wrote:

> Documentation/coccinelle.txt suggests using the SPFLAGS
> make variable to pass additional options to spatch.
> 
> Reorder the way SPFLAGS is added to FLAGS, to allow
> for options in the SPFLAGS to override the default
> --very-quiet option.
> 
> Similarly, rearrage the FLAGS for org or report mode.
> This allows for overriding of the default --no-show-diff
> option through SPFLAGS.

The first looks like a good idea, but do you find a use case for the 
second?  The diff that is shown in org or report mode may be sort of 
random.  It is just an easy hack to reuse the same pattern code for 
context, org, and report modes, but there isn't an intent to see the diff 
produced by context mode in org or report mode.

thanks,
julia


> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Gilles Muller <Gilles.Muller@lip6.fr>
> Cc: Nicolas Palix <nicolas.palix@imag.fr>
> Cc: Michal Marek <mmarek@suse.com>
> ---
>  scripts/coccicheck | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index dd85a45..f662786 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -25,7 +25,7 @@ else
>  	NPROC="$J"
>  fi
>  
> -FLAGS="$SPFLAGS --very-quiet"
> +FLAGS="--very-quiet $SPFLAGS"
>  
>  # spatch only allows include directories with the syntax "-I include"
>  # while gcc also allows "-Iinclude" and "-include include"
> @@ -72,7 +72,7 @@ if [ "$MODE" = "chain" ] ; then
>  	echo 'All available modes will be tried (in that order): patch, report, context, org'
>      fi
>  elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
> -    FLAGS="$FLAGS --no-show-diff"
> +    FLAGS="--no-show-diff $FLAGS"
>  fi
>  
>  if [ "$ONLINE" = "0" ] ; then
> -- 
> 1.9.1
> 
>