From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933120AbcFLVJg (ORCPT ); Sun, 12 Jun 2016 17:09:36 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:53333 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932426AbcFLVJf (ORCPT ); Sun, 12 Jun 2016 17:09:35 -0400 X-IronPort-AV: E=Sophos;i="5.26,463,1459807200"; d="scan'208";a="181010932" Date: Sun, 12 Jun 2016 23:09:30 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Deepa Dinamani cc: Linux Kernel Mailing List , Arnd Bergmann , Gilles Muller , Nicolas Palix , Michal Marek Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags In-Reply-To: Message-ID: References: <1465758279-16111-1-git-send-email-deepa.kernel@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Jun 2016, Deepa Dinamani wrote: > >> >> Documentation/coccinelle.txt suggests using the SPFLAGS > >> >> make variable to pass additional options to spatch. > >> >> > >> >> Reorder the way SPFLAGS is added to FLAGS, to allow > >> >> for options in the SPFLAGS to override the default > >> >> --very-quiet option. > >> >> > >> >> Similarly, rearrage the FLAGS for org or report mode. > >> >> This allows for overriding of the default --no-show-diff > >> >> option through SPFLAGS. > >> > > >> > The first looks like a good idea, but do you find a use case for the > >> > second? The diff that is shown in org or report mode may be sort of > >> > random. It is just an easy hack to reuse the same pattern code for > >> > context, org, and report modes, but there isn't an intent to see the diff > >> > produced by context mode in org or report mode. > >> > >> I thought this at first, that org report mode wouldn't need it the diff. > >> But if a user wishes to override the option, then why should we not > >> accept that the user knows what they are doing? > > > > I guess... Another issue is that the org/report mode output comes from > > python, and the diff output comes from ocaml. They are not synchronized. > > Ie, the report won't come out next to the relevant diff. > > Ok. I was just thinking of user as the final authority because I was > trying to get more > debug output for my script. And, yes I only wanted to override the --very-quiet. > I just thought since --no-show-diff was a similar issue, it would be > good to do the > same thing here. > > Let me know if you want me to leave out the second rearrange and submit a v2. I think it doesn't hurt anything, if Nicolas is OK with it. Thanks for noticing the --very-quiet issue. julia