From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116AbcFUVfy (ORCPT ); Tue, 21 Jun 2016 17:35:54 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:40444 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbcFUVeb (ORCPT ); Tue, 21 Jun 2016 17:34:31 -0400 X-IronPort-AV: E=Sophos;i="5.26,506,1459807200"; d="scan'208";a="182059137" Date: Tue, 21 Jun 2016 23:31:00 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: Gilles Muller , nicolas.palix@imag.fr, mmarek@suse.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, markivx@codeaurora.org, stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com, broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, deepa.kernel@gmail.com, cocci@systeme.lip6.fr Subject: Re: [PATCH v3 3/8] coccicheck: enable parmap support In-Reply-To: <20160621212733.GY25646@wotan.suse.de> Message-ID: References: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> <1466536893-23355-4-git-send-email-mcgrof@kernel.org> <20160621203958.GU25646@wotan.suse.de> <20160621205441.GW25646@wotan.suse.de> <20160621212733.GY25646@wotan.suse.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 21, 2016 at 11:10:00PM +0200, Julia Lawall wrote: > > > > > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Tue, Jun 21, 2016 at 10:43:04PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > > > On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote: > > > > > > > > > > > > > > > > > > On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > > > > > > > Coccinelle has had parmap support since 1.0.2, this means > > > > > > > it supports --jobs, enabling built-in multithreaded functionality, > > > > > > > instead of needing one to script it out. Just look for --jobs > > > > > > > in the help output to determine if this is supported. > > > > > > > > > > > > > > Also enable the load balancing to be dynamic, so that if a > > > > > > > thread finishes early we keep feeding it. > > > > > > > > > > > > > > Note: now that we have all things handled for us, redirect stderr to > > > > > > > stdout as well to capture any possible errors or warnings issued by > > > > > > > coccinelle. > > > > > > > > > > > > > > If --jobs is not supported we fallback to the old mechanism. > > > > > > > This also now accepts DEBUG_FILE= to specify where you want > > > > > > > stderr to be redirected to, by default we redirect stderr to > > > > > > > /dev/null. > > > > > > > > > > > > Why do you want to do something different for standard error in the parmap > > > > > > and nonparmap case? > > > > > > > > > > We should just deprecate non-parmap later. > > > > > > > > that's not really getting at the point. I like the DEBUG_FILE= solution. > > > > I don't like merging stderr and stdout. So you've put what to my mind is > > > > the good solution only in the deprecated case (to my understanding of > > > > the commit message). > > > > > > stderr is not being merged to stdout though. By default stderr goes to /dev/null > > > and if you want it you specify a DEBUG_FILE. > > > > Above it says: > > > > Note: now that we have all things handled for us, redirect stderr to > > stdout as well to capture any possible errors or warnings issued by > > coccinelle. > > Ah crap, sorry I left that in the commit log message by mistake. > > > If DEBUG_FILE is an option for the parmap case, it should be mentioned > > there too. > > Indeed, its as described instead, stderr goes to /dev/null by default > unless DEBUG_FILE is specified, if it is specified then stderr goes > to DEBUG_FILE. OK, good. julia