From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751554AbcFVFwh (ORCPT ); Wed, 22 Jun 2016 01:52:37 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51555 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbcFVFwf (ORCPT ); Wed, 22 Jun 2016 01:52:35 -0400 X-IronPort-AV: E=Sophos;i="5.26,508,1459807200"; d="scan'208";a="223387677" Date: Wed, 22 Jun 2016 07:51:39 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: "Nicolas Palix (LIG)" , Gilles Muller , mmarek@suse.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, markivx@codeaurora.org, stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com, broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, deepa.kernel@gmail.com, cocci@systeme.lip6.fr Subject: Re: [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle In-Reply-To: <20160621233851.GJ25646@wotan.suse.de> Message-ID: References: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> <1466536893-23355-6-git-send-email-mcgrof@kernel.org> <3617d9eb-7f8e-a230-a78e-a5126abcbc2f@imag.fr> <20160621233851.GJ25646@wotan.suse.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-941235950-1466574703=:2082" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-941235950-1466574703=:2082 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT On Wed, 22 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 21, 2016 at 11:12:54PM +0200, Julia Lawall wrote: > > On Tue, 21 Jun 2016, Nicolas Palix (LIG) wrote: > > > > > Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : > > > > Help Coccinelle when used against Linux with a set of sensible defaults > > > > options for Linux. This hints to coccinelle git can be used for 'git grep' > > > > queries over coccigrep. A timeout of 200 seconds should suffice for now. > > > > > > > > If you use idutils you can override for 'make coccicheck' by using the > > > > SPFLAGS option as follows: > > > > > > > > First build the index, for example: > > > > mkid -s > > > > > > > > Pick the cocci file you wnat to work with: > > > > export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci > > > > > > > > Then run coccicheck: > > > > $ make coccicheck V=1 MODE=report SPFLAGS="--use-idutils ID" > > > > > > > > Coccinelle supports reading .cocciconfig from different directories, > > > > the later one overriding the previous reads in the following order: > > > > > > > > o Your current user's home directory is processed first > > > > o Your directory from which spatch is called is processed next > > > > o The directory provided with the --dir option is processed last, if used > > > > > > > > Signed-off-by: Luis R. Rodriguez > > > Acked-by: Nicolas Palix > > > > Hmm, I can see at least some advantages to encouraging people to do it the > > Coccinelle way, with the Coccinelle script rather than mkid directly. > > Then, if we need some other features specific to Coccinelle, we can just > > add them. > > I can simply document that if users are used to using their own > target output file, and if they wanted it to be used by coccinelle > simply symlinking .id-utils.index to it would enable coccinelle > to pick it up by default. > > If that is done, would the new .cocciconfig not override though? I don't understand. julia --8323328-941235950-1466574703=:2082--