From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753133AbcGMOwp (ORCPT ); Wed, 13 Jul 2016 10:52:45 -0400 Received: from mail-by2nam01on0050.outbound.protection.outlook.com ([104.47.34.50]:51664 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753300AbcGMOw2 (ORCPT ); Wed, 13 Jul 2016 10:52:28 -0400 X-Greylist: delayed 70836 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Jul 2016 10:52:27 EDT Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Wed, 13 Jul 2016 09:47:03 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Russell King - ARM Linux CC: Moritz Fischer , Mark Rutland , Devicetree List , "Ian Campbell" , Linux Kernel Mailing List , Rob Herring , Dinh Nguyen , Alan Tull , linux-arm-kernel Subject: Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support In-Reply-To: <20160712222029.GW1041@n2100.armlinux.org.uk> Message-ID: References: <20160712190709.5964-1-atull@opensource.altera.com> <20160712190709.5964-3-atull@opensource.altera.com> <20160712222029.GW1041@n2100.armlinux.org.uk> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR0701CA0012.namprd07.prod.outlook.com (10.162.96.22) To BN3PR03MB1509.namprd03.prod.outlook.com (10.163.35.148) X-MS-Office365-Filtering-Correlation-Id: cdfe3b64-7cc1-4b7c-8312-08d3ab2d2e93 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;2:xkHYbQkMjWnK/BC13VbdZ2WdTqhdfDVij3X2Ir3Eos7hWne4DfSbtRk++I2MSiXCPQtOe1rOWU3IQb3Qy63QCcehuQcONxc7jAwFPIyzT2ARdCUEl6RVcoFolbIE0rYqXWQ3wQmFCk38cvVDKaM+UVgLI4IEZPT5JICyD/H9Ypjk8zSYCOYLTimLjwG+0jTE;3:+eqZ2YNUhpEktpoCv6+eAg4Ns80wRSI6iaSK6Za79os81rYJR2A9N5PZOfoP9svpSXlwaBg2xjK1RMK8GCwPWWSXA4xWvTjOtrYTLpo6tAIU0d2Bf86g8QYFN06X8Qd4 X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1509; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;25:u/1teCRjXxb5Zcp1nCgDNYTvwQag2kmaS05MYtQ7nVswh1bx3r4Qk27JCGoQh7syD+GvV1QcgXaK5TWwchcJ3rphyHAOAUCJA5zLBFK/Npr6vJBxDHQ5uuuFgsl2t0sSL50pB684di71r6sFxlryKp0GhjCtnie1SiH7BjuxomEFG9XC6+ediAgZZRu77MktCqkTLm8i4CZlI0bzcSv0fSJfLMQIVwVaCxlzrIkK26XH5h4FBFMbaR1tPGInXf2Y9OBBz/CUg4AukKt3Q7U1r8krF0AkOQs17hRvLrn9luZtv1MbiBRQJorg0z/aI9sFWiuNUj4KxQuujOVHd1spc99lUI8jvoBbikqNrl9iKMlqYg5vik1p5kgWIlpgTmc37hrukZZ9q20s5mH9zi6DDSNJlms0IU9wOBiDyQNX8dCaEi+cEBifxxx+ppWGrQIcn/DCW/j+lw7K4fXzRB159IgziuDpU8A6Fu2UbWAP6ZQs8vczw3xpHXuiZkmXhCROLRmJWh/oXtlnYRFisVzlB2Zi3l6dqONsZBGb8hkb7aErbNLjgbXDEvM1b9yE4PDtEmQCSIcwOQjKNa7jf0PGnTGPJtmOnETS9ZF5ui7zdeia3qphWHbjFNW/+yTkdSxr7+cMzcFJVyq72HZccFwUrNxW5IeNDK1JMWDYBWqiFrO8UBEl6REjdd7fwVXuaCX40/JUjqaLIu0ihoMMdKW4kei1dHLrwgbdaJ4ke6HNfKmQTQFgowQFgycszc8jdz2R4oEaUKqVU1abyCCZo8W1e/GES+nNye1cqfL0/4GzZDTMj66OSoPEAPh7br9ITgFh X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;31:mQ7Ur4beyoJBVo9BmvJldS+4zbzEkVX8LwRPHE5wLyJ5v6+5UCimw55Hdthp6XoSDLgTDgv9AG/rReKaxUwsXUy8ZS6dotAQ7aZG+gEUmRB1Gyvk56oc9gq2pF5wiIS7aAgWVcomeY+cHpy0yke5W+zo6YK118FPO2Ho13CtDVnRi/u7qwbzOJjEX3o2WoEnVjBeC3JOuYo8gL40gc/ExQ==;20:9GacXjKFvWFPi2nQ0uhFS+/RaihmxKvXf6RJqsqo7ktQhWy0FzZlvt3hsGezbHqaq79QoHPoJCNlhFmZgPaL1GRkzLXAYoua8mFW68fcryywWpcRlHAR5GRL7HRr1czDj/hYuPgAy9mtsiQTyqaIKoxB5TI4ZyHxNeiMxVgLpg4=;4:TdbsShszbQpKAmgkqvBdhLZ5e9D+yiovKOBq7OIVj9VsGgEBnX6/yFdun2gDoFuGM65kS732dMpMD3BVvkckzyiFEWwviq8keXXRPHQAYcxgcHqcaHufblqatmHAVNrwsfZ09AbPlRkSUhctlXNke54o+pKbsaBK31Gf+kNBpxXlf2r7pqC8J4og+RxYIW5nQpQ/Trdj33LKAMqx4h0fv1OY6fPCZyUYv89jvXP7ZbcPBZhLQ912aWzmFOkCLUzsgxki9LzKC69oi8hRsnATjop4XkYQFIoEKrQILXp5o+80Zkzae25OE5H2HlQwsnflODqeMHM/1MN4FKDtB8WGHBDoPWOBHaFPuzOXnYAih28TDRDqY52jeO7QNfjh0Aq7B14RAKe/6MaWlDsyB1uhHEBVvKWGHUBfLHEdH+gj8lLPbui3xNv+gmsdUDW0B77Z X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757);UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BN3PR03MB1509;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1509;BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13023025)(13017025)(13024025)(13015025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BY2PR03MB410;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB410; X-Forefront-PRVS: 000227DA0C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(24454002)(377454003)(189002)(33716001)(110136002)(19580405001)(2950100001)(19580395003)(50466002)(83506001)(7736002)(4326007)(69596002)(6116002)(305945005)(2906002)(3846002)(23726003)(93886004)(46406003)(586003)(101416001)(189998001)(15975445007)(8676002)(81166006)(81156014)(86152002)(7846002)(77096005)(105586002)(106356001)(86362001)(50986999)(76176999)(54356999)(53416004)(47776003)(42186005)(9686002)(92566002)(4001350100001)(97736004)(68736007)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1509;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BN3PR03MB1509;23:Iy7aLl/NGT4R5eWxYg/h2L5FlWkDmwYmVI5XjiCmK?= =?us-ascii?Q?8EOPrGvDxmhC36t+lgtqfMUKJEegvAnPC/evEJAqPw5eIJD/NMvz4SX1Pbz5?= =?us-ascii?Q?Kwy4mC22UnQ9vhkJXl9c+pvVW782iHagwmLo8o//W7TNyLmHEW+y1T5YmR75?= =?us-ascii?Q?iuNVg5Z+GIEyJ/8+IPd2Hu44OMMkJHKhgSa5GHuJLU5HwBHX4mU9NC9eQebX?= =?us-ascii?Q?xKMSqa++gwwqqBlA4Bc4u/FKKFaIP/cvyh91i/6j0zjpZmoNK3D5QFrpd95W?= =?us-ascii?Q?8MW88O5fVq/n4Fpj2zszBylIWPnlAKtYAOAUoCNfK/ktV7iUkIUbpHiN4AMp?= =?us-ascii?Q?uUZ6C6vEksh3uBgUwPNruddE5OOzQ/5Rko6JCpZ7S7q6a+dBAVSx/BzJh7/W?= =?us-ascii?Q?QL62j+Ji7QzvUWjI2PEj0PkQ95NX9MXtgZx0R7uYoW+04kOVeU4p2JL0fSd0?= =?us-ascii?Q?WKFBoZaY3ExeRNPbJYMVqW9Fk1gU35NCxugDesXp0N3ALji+Ox9AxQwJOroE?= =?us-ascii?Q?iZFbLdGR0p3oiW7gPrVTRVe94JbJxz6nclsMIgJLsZjMjC96frSQrCPpBtuC?= =?us-ascii?Q?ost2f3msg2Nb1UTAdaTCBCZMy6pib0bEWYYhNY0SEmqCTeF/jZHbOw46mBcF?= =?us-ascii?Q?QtLX3D234sX+1wSTnxHT9mvZ5qFRbKP81TYVwHXTwdxXE8OBQJQelGjlPFlI?= =?us-ascii?Q?8oUP+yl/OJXHvMR99GeCY3tV6OYG4UBAZetEWK3t5u1Bs38a8JupLcJHxfiI?= =?us-ascii?Q?KD8XjAJXFAyDTNFP+Gpp21lMIqf2LvCskEu+exXEp1ZMJJbPvt2Y+oS33rL6?= =?us-ascii?Q?X8bXkjVEnLfxdF9ClSJT17J6SLenulTqQsBW5Ij8oW4/amBAwJ8m/wivzFUp?= =?us-ascii?Q?dFvlodeY+o3mFJhD2Q5ew1aO+NKQe0O6Ssp9DjBTizMcsmOq/EmbQxokOIJS?= =?us-ascii?Q?2xrHeQEp1fd6IrrF+QisdidMVY7OKidCaZdVtzynpRnxTAD0YzfxOTtpxSJP?= =?us-ascii?Q?VxKx0btkrJwDbhkBBHaIqEWSMNVm93ji5iz8uaihfzlPspbLANkexrCLVHiK?= =?us-ascii?Q?k1JMDqz7XFahV5vPzWtbtrl5eVAC+qmk239LBvuUD+jAqHCVSNDJT5Y2noVa?= =?us-ascii?Q?dWCxYboTMw6odSuK1hsy8T9PFyp94MrZGIB42o3V3gEnn6iZA8gEEG7/Wstf?= =?us-ascii?Q?MjrgaopVNfW3h0=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;6:S5+h4Z9C9qOR5Dve7UICQ9TISiZC1vjUf7BhTFqaZM3zsoboDRm0okJd/r8Kh3qvD5Yl4N3zwVxNaCdXbSsF0B6jCiswZYIl+9A2xdUQAYsBf30YdlWUuwEUNuUZKnLXUjnkKVx49oRLS7NTgBLQeY0F2+NLjzfpAn6TC0lBUWULeq/EVw4jV+D8+usspGmsJVJCd9LqpjRXAJg1Em02PkazgLhHfuFs7mND/Rr+Ve4Hsmp9g1BfqqpbGltDinFO9LRk25rFjHXzaPrx7jYd5S3voccr2PDvYCUcCG6nBxHFP4k7ONY1VRBLGyTirm26m5jXEfPjtByp0Huc+Y7RzQ==;5:a3WEgc/t3cRnrHbsqGd3YuoABluPR9c1hkuh346L1pXAnn+kxp3XlWZItiL4/KQ1MO/nP8SGPSlv1jG7tCxe/GMNiO9RQeTQ8nDJjBudGPf/lBzovwYqOEntfuQS+juAtdU73D803g+RoBNlXemxqQ==;24:NkycPF/7Fq9Ty60ucblUqeiKs8W1uQQS2+EDIhsKPUp3b7x9g4BNpmNcqYcx8oN/B6yDqNC3CIosZ7EvntrBtAMJMF+MoNdEiJob7FrrKjk=;7:rk+eEi8TT7j//qf4ofJ/ujSGgtem/jKJ4ZmXcbcLZ5XlREtE4C8rc/3G5u4wRRHuUo+auvVy4hXyZgC2wBNeWVIo97XzVkzuQBghpDV0FnfpIsSa2rivbXj+24dDwBS8Dysn/fsUrECUrcNDwkkBM3KjseD5a5u7vVkODVH0VuK1LGiQBQLl/LqHiuDNw9TCORXtB7T5c4qhtpvX1TNG/u44e1a7Hni8Ug3OEPR5FgNzcxyCfFoof7n9au/OrM48 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1509;20:l87dn33Q646LQflDZC8Yjk7JBFs1Vh6eO8opinRUkmgUCXq3DrBRFPJxdwIw4su8/cvM6fpcetID7irr7rkpFQgyEZJeVZHSHEsWz2dQ1usJT+NHA7uMgu+00/9qkYLsl+bTAYnp1Ogsle1+fZ0puCHjdNS6XjWjeSiEmQEU5r4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1509 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11FD014.protection.gbl X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(24454002)(377454003)(199003)(9686002)(2950100001)(81166006)(9576002)(50466002)(105606002)(53416004)(16796002)(6806005)(50986999)(54356999)(76176999)(2906002)(189998001)(305945005)(356003)(7846002)(3720700001)(8676002)(83506001)(106466001)(110136002)(8936002)(19580395003)(92566002)(7736002)(46406003)(19580405001)(33716001)(81156014)(11100500001)(85426001)(4001350100001)(77096005)(86152002)(4326007)(86362001)(6070500001)(586003)(6116002)(956001)(3846002)(93886004)(87936001)(47776003)(97736004)(15975445007)(66066001)(23726003)(68736007)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB410;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD014;1:G5rg/D6Y5LbNKRZb8wXaGBQlqgd7sXTKkatMNCGAJvCfv1tTf8MG5+skOsEakAXJNmoOuCgvN0zgz1K6fwdzLNrjlhl2/k3G27++iiXnIv7OFSCBV6HesoY4zxqjPDn7H7PsXhNEEHToo807+m274uipKeIuycTmAzsCiPZDeORwRMXEPcQH2WYQpFu6OkUjEstcgeYhCb9JV9fCwOUc9SIZ/y94MbtNjjA//vZczZUF2jaHd4MhTzaUYWQeglt9F/ZOkItSx8ZTEeD70woOPl9Ov6GvHPRJ3XhK18dpPfEahvAD+/zJNb0ElSKDdvGAqQ9jodhJO5mXUajPbm5K+CfNFElb4P5BemG6yaMlJANryzcT3Ubven6pjRfhYq1OYOkrn6m4hyGA8M+uNpLx3c+WG9500/qWdsoEulRMqZrdlReFSmYG+bdJE0/PkP60Y8cZ0KPD+NE1op3MqzrfTDXYiE5u/sKyPP8zkCt2uYr2fC83vk4CcbZu+qosDtZk/e3xAbS7a06JgN/+/9p/oRRSOZbPNFA1w+7PDoJOdlrJ0G9hdZvNco4jSNn1btLk5CsYVkP98mgMhFsvKFmGew== X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB410;2:LIbnNYX3xjyxHc7UiMispTpSVKXSOhkVoXzEr0K3pPcn+/1LiZNZ0IvlVahqaI1JBkmPkqVRZpz5KgtzaTNQOn12jK+vVmkJFLcX8pR7gzNAnmOo1aehwqTNp16yfyUG+1v3eUig8oj7Z/+AI30lov3Lw9Wr7JkgvZNA0Mcpz11gvvpfV4JIWkAO++SuKDrZ;3:nDRXZ2ZRXM/m6sfSH5H8X2TMk0Zs8lKRziAi8axBmUqtEy5Pgsz/Zh+HhxGHkwPziYitn4kqJKfIbCexG78yGNusAhkCAP3j+Jne76pJDM4W/q7N688fL8yiYq2cJhJaQucOrsKr6nlGh2s+FROinRQRX5AsyK4NXdiD4dqCYfpk6SrMT30wx07jYecNmvLH03ZlOTCHNKT2Auj16iKmIbDAgKUQvCxIH/l8Xx4uizD2nt6B+QdDhyTmOtAZiP2g;25:6QF+2dfhsLLFYNoU7yFrlVNigMZMqhmuP6jr/JI99r43frC7sit42oYEU62hyye2e9HHchSLP+EEOdzsU0iOSiES5L+cJgR50eHtJ1GhsfcBh5uZlPNVd8JzTeaINdvbWELSaFVfuWXE2Saefz5O9OsLJmHTNsW4E7MbQ/LtJJTOXf9uBVEr6RmiBUmnCftuLgdNRhABNGy9Q6ybSm7zThJpmu6D8DZEETv6DB8EKRcGWTEpYcLdYua8+QIvXAKo/oEQ47r1o/DKDO8UGSphBXrP9YOZdbHpQMzXI8lyshx2UNmA5kLvWU+lXUg+zQA/MF5So4iMCmWgDb4m6gnYl+/SYp21+dsBDlexkD/gWQbHdxNifqVoMvHkaib+kVUQLju00YScrchl3e8uAEP3kjJ9u/8wCpEI6SG1SCuzTdw= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BY2PR03MB410; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB410;31:cchcoy7Rn7omp7/uKCPNo3ckeI3Ax3hlMcKvqpeexn9NfjSLZr6gIpo97FqjRGJcuJGM4HSeRc7X//BNWo8e1cW/DPSfK3I7hHCs3yea8K1Q+lgXj3mLo06pEhhiJmmKjjAQMi5yimGF+P36qoQ1LmPHi3laRHvoKd2ONdoLeectP8SgfXQphf95zLaAdDcX+XwXF97gsebnK84h+V9sYQ==;20:EXbC76Q40Vei8Sli4YSaC5eUiE8ShsdTot1IxfJ0iGJLAaSOmU9np7HNcY69J20GTkGc/cNkjULuzFQ0oj0IhoEnFlHfU6mtASLCr74lBKGsRXP/fJhAlJy4GjPwnUhN8jbm47hiUHR0DBnGSgyeDvFjMAXUfn8FuCcYkj9Ykms=;4:8rIbyPRS9+YxtqtFox6KFcrVXRVbSLJTOey+H6VgiO+ayncVjf8cz416AfXuXv32Jh6z+9AqFbYgJpXnI2TL0wCurdpQXQu1jrLTBGcalS0YYPN3AtL6TXozdjn5hWpbtM9X6CvMifWrgYlnbhAV57FQyxx8J0bfQortW1DZQzBtRQhhZS3J/8dzF1yrOnAm+ARwPK96i+elwuSGSBzlapdwDH3TsVxHa0slvWb/xSKGFY70INn9s4JWiThboMaZFQzvO/JyTzN7D8aPAsh8hMTyqRXKctCitKX2R0fZTTdZkvCPtQV9kBCxesbamuw1vh45tUpWollXVd2eddztsqHQjrqAccfOT9q5DeGQQHulBy5ldAXTyx1Lg/F5qASOq2rgvarhevNLDmZdzKZ3G0paGCPRxvkQKyN+v4ZjnQoMy3zD5kSmAVKKXUH4SU0vqq91PUU9UH0ypDCgLOCNr51TwlSbHcXw7aQz4vbnSNzYsgl3bfuGXdbIYMHKEXkH/AHcmegPccq5mdBTqR/ydA== X-Forefront-PRVS: 000227DA0C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR03MB410;23:M7TGEkfv1S+CkgokGhAFJpAZFqERWjFi40C6V1EdSc?= =?us-ascii?Q?iRMyH85qMwQFgjYy8mESdtyxi66tzw/mXCZ0EtlS/QY/y8ncT/pSm0JV5vpm?= =?us-ascii?Q?ZRBWgE5t5Dn/vRR1EwjSnhsbfMH77N4YbOPULn/cSjZfX8T+X+Row4ADqxyr?= =?us-ascii?Q?VX11HGBgpsa9Wiux7gE8RXcNQz+AKpmIv0UbpBogTrGnSiSzh6t3djn4jPFw?= =?us-ascii?Q?g0WKpWDIghZCyIxRplrUEUFxFtQEaWsmy/bi7ze2rU5Xydp2kw2Wx9Cm2gJ4?= =?us-ascii?Q?5N5iTqmivvhLf0oDEGLr1fVq+b6fByry8MmrNJbgOMEut/ijf82amCBGVXOE?= =?us-ascii?Q?EIoae5dOhCQbbIVipGW341lt/WpG8wQorCS3Xf5ELhSf5XRAwNl/DwADOGnQ?= =?us-ascii?Q?twOAw8cUVNC7Tid5AfQgKb6wEgNomj2vQjQONIA72ucT+5wpXXWQBrr9PqP2?= =?us-ascii?Q?RsA04CqhBtNQtHEQp5hTY4t5JIu2Cj+rrQ6RJOFUYHp6zuK+KHaOb2tfWrYM?= =?us-ascii?Q?HHjmbJH4zdso/fPwozZu5QfvxILRAqbrZcXAzRvvN7+DwXm03yzQCEQoCqFK?= =?us-ascii?Q?ujkT2rIpRzrFWm2pD2BaLA5qwB6qLil4a7PH05wSJh+BlmQnExmEPnULeNg+?= =?us-ascii?Q?TxJovvztoPWnswtky0JDTodj2U+p4ZuZze9HTvVcUIPEQeCZVSYvy+cvWD+4?= =?us-ascii?Q?LXti8voeHlyfV9iddJ5ldkJRSdpkXUntnONMM1OI2j1yKYCVKGFyRH0RNjQl?= =?us-ascii?Q?9wAe6qmXuppr/ZICHgyNHUD7OFE/FpRyMv00qtevnFwDvoUk9XuVEd1ZpCnE?= =?us-ascii?Q?TZjV7sjlYxWGS6BRLCY6UM1dCuwITSCdOHXDmIVidQ2e5C+T0+4+qOJ+zHbD?= =?us-ascii?Q?7koKel/1U9Rcl0/C0LVBMi/rTFo96bCVc9G+6EK+UTAx3rO43vFBJgQA1frL?= =?us-ascii?Q?QRBo9BILzTPAE+0jvhA3l30OmWGEw+0+N5hOpk6i6xjMBdBCYsKusxH71UuP?= =?us-ascii?Q?exMOr6bXMpxPHF7gyltQnLAToRMVhXglMrcIDI6YjP8B3jk9nsOdXwx/WBJh?= =?us-ascii?Q?CCSHTARV86L9iE+o/fkHnAhJ5lab3FNXkn3PXqWEg3+ApUZ0i3intWNeeLiV?= =?us-ascii?Q?ShbKUS6cB9b+IZJh+FkeHl+zkaT275j7ax/HPJ0qA8rbjHf5e1rT6F5/5KL9?= =?us-ascii?Q?u8qX33tdidWUeiUMWERJRx/7Pkbl2pE7gT1UzvNQChpjtyXflKCzUI7vKNZ9?= =?us-ascii?Q?xshgzeZ5D2NEBfT9xRUlDBaDNcwuQOncSrLi6+9zn4vi5BmMgiR5JjJnsg3t?= =?us-ascii?Q?XU+TaOQ2P/Bd96rCKXJUEfZ2J6yLN3GErenVoxW2yxFpTgWiHOOdzCuQXz/O?= =?us-ascii?Q?4rOB5wgVZxGVb3bGRp5e6Aap4cbPs1PsrF/Px5EhbZn9EKfO0y7+Palfnjea?= =?us-ascii?Q?k1T4MiZ1DpoUVphNPiifE54aUiii4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB410;6:qpABboy5R5TGFbQ0TbwBj23nV1SMIZSk4IgFAho7by3TEdJpOTsnUnd8SX3sULqWd5/hr9Jjn86nU/RX55bnhVFOFTKsxWyzKQvm160QF2p1m4YvJr9rQP8JndsJYoJdsw48yljzw3GTqCBZMQoiUoonLeLNbqTS1zW5w9ortZcqT6GeQcFKzB6iV0qpwHng7l3ZvvWdBhjV4gAakbhEM0ovAc+1fPs2kPbVFFNF2baBQ8wfhFEqBq0GePpeoc0msJSfJuutedN12GEQ3qyr+/gvEfmHJY1MNb0WmLNmgXMqw0IADeQOuLB7h7u3qH1D3Q7+BlWJc7dvWXfIo5BtRA==;5:xvEpW71dUVSDWzks9wc+3rlsbYnsRn5/0jMByoySuaz1NWD8zNWZDGfpzK5enCp2iDuNg/vrQzUcKqgQbcN8zkVfwXL8B0pavEd+UAEXuBbpukqffCvi5r5DRxTP4zTsfqdOq4I0NfJKFRPLsSSppg==;24:pEu3/aNdKgs6kyxrx/41rLvo0ZtyYCf5/Q2dp//h+RJ/ydMEKqAaLGMOiowAYPzTI8D3ZqItAVVSYe2wRCMrMqSu6jm8EsFq3qgFQolO7ms=;7:SOUldUg7ofZbfYpa0fJazJA52K+E2fhB+2mvSJh53qfgne1zMa2QH6nzZ6mGH8yB2d54qMbeQmIq+ZYNdMeAP6Xk8ZeYnepm3dk3Ts77uyDiWWUG2kkYdLrdhrKEhbbz3JftU+TzQYDFUabNMuivcXMa5GHL/G4VootO2Mtc+c2+3yG+YnC+aNx97QZhvNREZf1jpmv+hb/ATaDwlNoIJw== X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB410;20:sgQfwKwdUIhNIUtlpQKqC6cJk6vcBZSvDL2IUsp8oxWAGDUUeqaelKACJcApXKWnBHTx+xrSFx3jbjiJUaxJW+sw0IRlXCwPaALiOlUto4d7hhMtAEGfjEqZL+9TX9GhS9K6umrjg7YV1SiIjOm4RJyQ6I4f2H5Ij+PQNIAR/GQ= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2016 14:51:32.8769 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB410 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016, Russell King - ARM Linux wrote: > On Tue, Jul 12, 2016 at 02:31:05PM -0700, Moritz Fischer wrote: > > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull wrote: > > > + priv->clk = devm_clk_get(dev, NULL); > > > + if (IS_ERR(priv->clk)) { > > > + dev_err(dev, "no clock specified\n"); > > > + return PTR_ERR(priv->clk); > > > + } > > > + > > > + ret = clk_prepare_enable(priv->clk); > > > + if (ret) { > > > + dev_err(dev, "could not enable clock\n"); > > > + clk_put(priv->clk); > > > > Seen that you used devm_clk_get() is this one necessary? > > That's actually a bug. Yes, it's wrong. And not needed anyway. > Never clk_put() a devm_clk_get()'d clock. > devm_clk_put() is what you want if provided. However, I think > this clk_put() call is useless here. > > > > +static int socfpga_a10_fpga_remove(struct platform_device *pdev) > > > +{ > > > + struct fpga_manager *mgr = platform_get_drvdata(pdev); > > > + struct a10_fpga_priv *priv = mgr->priv; > > > + > > > + fpga_mgr_unregister(&pdev->dev); > > > + clk_disable_unprepare(priv->clk); > > > + clk_put(priv->clk); > > > > Same here, if needed at all shouldn't it be devm_clk_put() ? > > And also useless here, as the whole point of the devm_* stuff is to > clean up the resources that were claimed on probe failure or when > the device is unbound from its driver. Thanks for pointing this out. I'll take out the clk_put's. Alan > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. >