From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934890AbcI2Vu0 (ORCPT ); Thu, 29 Sep 2016 17:50:26 -0400 Received: from mail-bn3nam01on0080.outbound.protection.outlook.com ([104.47.33.80]:32730 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934781AbcI2VuM (ORCPT ); Thu, 29 Sep 2016 17:50:12 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Thu, 29 Sep 2016 16:35:39 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Moritz Fischer CC: Rob Herring , Frank Rowand , Mark Rutland , Greg Kroah-Hartman , Ian Campbell , Jon Masters , Walter Goossens , Michal Simek , Cyril Chemparathy , Matthew Gerlach , Dinh Nguyen , Devicetree List , linux-arm-kernel , Linux Kernel Mailing List , Alan Tull , Subject: Re: [PATCH v19 12/12] fpga-manager: Add Socfpga Arria10 support In-Reply-To: Message-ID: References: <20160928182200.15800-1-atull@opensource.altera.com> <20160928182200.15800-13-atull@opensource.altera.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR1001CA0081.namprd10.prod.outlook.com (10.164.163.49) To BLUPR03MB1505.namprd03.prod.outlook.com (10.163.81.23) X-MS-Office365-Filtering-Correlation-Id: 220f798b-4cea-45b7-3067-08d3e8b083bb X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;2:e+qHacRJKXVSvmTXyJ5dq3bZjzKmn2mUMg3h6SmMVFLrSNoZp+9M2lPEd3GE+2Ee1cKrPl07lw/SHaybovDPG0ejfjcC8VDgO1/S7NQTXFaL0VRpEzY3xt81k2EK3n/S54Sjqr9ppmdMkqE9JrH2VhWRX11FX0Ddyp5HvdR/goOHJZRDfOlESBnXEZFo5jWA;3:QBBA9snnVJDY+MtDdPO+5P9Z0UtNMXS+xskK9VNYJdHCeps9zBW28Nn0WT3g3vgP6T1PqXsN/ARLEv9uXpwB52X++dfHF8gEUBswJSbQFCcLeuGlkqt/VhTWtlULRBeM X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1505; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;25:2f0143UQq7GpDgQyUwnzvmm2A45kAmM8DLYXz2YwVZAbC3s4L7xpihUmE/gDV2pdvUI/2FQ44gts4fzgCcjmWfMkzrL8hjjLnkPRtMaTMXqko485ow886fzclGXuYo6GnhAtfoyGRzS58DtTwNfLXehaW9JK57SJIn8N9ExxXpUn+xEDg6lwUvSo2sx8bS+qkBirlLaL95VIkUBFZaSwnDjrYtXWk/8q+SxIDtvQTyj9fRWXjngQuSHU3apGhfRGwsqIwc2mbdXJC8cnO4EN4ctqIqG5u820tis91o4oBIqvX0EJpYBtbt1tUth2sZqNRnOila2mb7QY0dJdPd+NpuuLj8ybuUjtQHp1xhzue4WbYGO0IigT+6gK1prjrBNqt7dmRaYlA1PKU9plJOpR1zb2wgN3fkqIn47vW9HvudVa95ho0FC4oX4WGXOBaGiq6CngddxnyEZ/Fyd1YdkS77K4Xi/NoZGNXszMtCTqb8ryjvT/uZWHIx9rq9CW26iVEbuDrr2ZLGBRxpeEx7XWWI/4bjZQY/PxcHcEMoZK0uv36oAl/4vRciuij2cmcXZFH7p40F2j4UI53WQeatLCNcSfhtBglGGG6OMBmI9Tq5zIolj/ODOVO7MqY0KBz0vTM9qR93ptHXHOjZDs8ovaUMeSG6o19u2BoUyRT8ZU/YhxVjJgY0dAYxHkO4wQWnl0FuOPlCjoCq1KDNka9m3JWz3uwNaaWaK1D5fyHSU8juk= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;31:SCEw44eaCClT27jlB3XUfXcZZtSuC4xYcFezgVZZqpo3cj0fNyYYfGZxFOQB5Wec5U40LgfP2jWvmoWHk/KlKB66Gpc/RnJ3J9zw803AUn9f6sfg93hfX71/Bfw5v7PT53hpQ7ORUHd+BOJF9JKrDZfNppEYKfN6IJmo0JXiVMmeBu7keA5gSjB2oJFcK26Lvg7RIIQSOGs/1+SeoMmPUAsO+nMt7YURlFfSsGCtSaw=;20:jTerawu3v/qbNU5tEL9OviyyFer5NtfyvRKgoYAdH2T73oIYpng9dmk3jd7Gfj1gZ8ruqw3ReCnwqMWA3wy2UcJ5chG9JOiIiPYXSbr3Ua7Myid2XSLeGfA6ldTaZK3QO7xP4xJyIvKu9NVJvc392h34VklKvr/pTU5XTFPtY6o=;4:VpPwtQlJSBleeIKo1w9sNS6vfTOsLpWqNPhvmxmQyQ8T8qbbC8eMF8WL3zU5HkVUAsOR/IvD0sGY0385pIHbOtCtm3E7qWAx1W+vsNCCqrH9h+ueiNWYX5cmczvMugyOULzDbr8hwsYCRn2fFEIlalXirUqJFWrQMZnY9RSeh2j94qmaa9CzNycylMJ3dDVmEt21PIKvQv1noRd+j2Q/xNlc3D7BAT2e0yiHJE5/5uYXfz6UvjoAxSrXss8CmDXsNBMn3rdyPrc26fXndW0or6rppRVEYy19EdgkqArB9cqKOiWrXV7+Y5oQXV8J3ZpyyvkQET2HnD43jsvcMtRGqlf46ZkPmYyW1g5n/SRFbKuilSiMK/2PkngO7hpMhPOYo1BqrQ6XyzhPi4+DvHXLpMRzPWFfdaQXORecaVFdwsdmEBMPAEcx9RdQPkB94sRslv8Pr6ixjpKpQKBfNJQimA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757);UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BLUPR03MB1505;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1505;BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13018025)(13024025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BY2PR03MB491;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB491; X-Forefront-PRVS: 00808B16F3 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(199003)(51914003)(377454003)(189002)(8676002)(4326007)(50466002)(33716001)(92566002)(7846002)(97736004)(4001350100001)(8666005)(81166006)(110136003)(7736002)(6666003)(81156014)(5660300001)(101416001)(305945005)(66066001)(6116002)(83506001)(3846002)(9686002)(586003)(47776003)(7416002)(76176999)(189998001)(23726003)(69596002)(46406003)(77096005)(54356999)(50986999)(86152002)(19580405001)(2950100002)(106356001)(42186005)(2906002)(42882006)(105586002)(53416004)(68736007)(6916009)(86362001)(19580395003)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1505;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BLUPR03MB1505;23:hpYMqwG8LmbFZoOfHEdKEZzr88Ql9AXGQ2qxeHVtB?= =?us-ascii?Q?eGm+vLQ/2X5TzXOxLgGl6wJv5PSujeo0Zsp/GCLNmmeD4GbIKrX5pXrRO1Tv?= =?us-ascii?Q?xQzFdUyhD5Qk3ug4VDfa+kBLyBujIC4tPCWouomI+0fD3wGxiQHgA3C1a98H?= =?us-ascii?Q?JArVnxXc1GPKIprPzfDJJaf6ImpqlBVPaOPnrRhCUgIYHagKFOb4kScn+fSc?= =?us-ascii?Q?T0rmI1wS5KcSekRw8xtZUU7lBuG8xNZiW8MluCY0WteWv0o98rSFRh+GFkcn?= =?us-ascii?Q?6qxD1CE/WHGKFyP9+ReW6WpSAYzUTSXadaLrqVsDuAS1leBTblk1g7BY053g?= =?us-ascii?Q?6vnFVkmOHhy6u9HkQlMBYWtWAGWaD4w17oZ0xI7HiSyorNro9sNKIcjC3ZvO?= =?us-ascii?Q?tBuJss+ej/ZLHTOYwE8h5Q1FUpFv5lIa90Ql3P4aX/WeVt7UQDIdfYwg64+A?= =?us-ascii?Q?7nJ3/Msi7lILQw1WfSxBiipa6L+DSB8AGpVqJ3bdIKRSOyZhD8RftlPifv1+?= =?us-ascii?Q?fGc8SHi8W+eJ4vtjCRGcWjQCY6BE/T9EKkVAqY4sbzVCfm6xox97o2HJDBtz?= =?us-ascii?Q?G5sWQhI+uLANNdiFtkury3FauayqYxOUGxfLuv9Z61p7qhEoFuii8eiXOdfH?= =?us-ascii?Q?FZtX8qULJTwk6o2w+264+hU+s9esxZkyO1rfbwsd2wxpafLrTL/k/XrW1Ynv?= =?us-ascii?Q?b9FwzvRZ8PFZCUYO/Ri1Of+QOxXLNkP4BDFUqg0tbqVGzUwu+zSN8BKsPl+J?= =?us-ascii?Q?ZJRsFL1W7oyu0mtigcxKTkHfmyZ9ZGQOoSzo+3YivaLGzZF90CuDoUycPizw?= =?us-ascii?Q?Op0JfcNEe8biF91mR0WHfNNofYdC5UqScW35qZFqIP7CGjXPSXhB1uphMtZq?= =?us-ascii?Q?aDj502SWdDbmIEeGs1TtXcvAkPL5ywFU2EbebCTlEKNnaH5mG0PhbT7ikI1H?= =?us-ascii?Q?Yj744Za4yn4Yqx9EnSls+2PjR63n9Q82LLNgZ47XA3lf8du4ew3Fq2e5Ip6t?= =?us-ascii?Q?qQHeQRLhvzN9LDOfkByrqPt17DVPOMlFRhrmuOVUIXQ2khfc4RMpxKahkP5U?= =?us-ascii?Q?pT3EE5u/S1NTCqlS7Y2rPUcG43t3+seZCYhUH0bCPRKw9gh4O3iPsx9L0fUH?= =?us-ascii?Q?n1j1TwMbCWeT3Gn2uGKxGkdzF/6W0Jo87OMSjB0Xek8E6YnspLLpwZWJ3sI5?= =?us-ascii?Q?YcuSsGTWC+w1HGD9NC/4KDwS3vWiltHsLEJ1lKC8/gz8IOc1iS6FEaU0QCp3?= =?us-ascii?Q?oFpC+img7PbHVwpC7qlOu/ynXrzs0Mx2I71R/lfnu+82sldyVdRBPDfSsqlw?= =?us-ascii?Q?WhwFniv/n2Ca5l9qfrD1Zg=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1505;6:0HScjz1z2va7l74Yp2deIGsd3sruKu457bJV11/P+7+FzEf25+zvaBjhdBnOeUIItx1h1LKX/ide2COXGgKv+flFIeR+p0QeZ6Wb+lfptEkW7OYgfRlyjmRQn2ay+67H1TsYO8ztuRIDFQl7CSXxoC9YwhQ1ylLgHroHaHELDGLuMjQ5Tkb4LwHH1bZd/be9v6Pdh1JBvPpbB57A6pZHYQ/PRqvwApA6iDUOY0YFb4z59J6qPM9E3q6iMlps2iRHK5uXNIe2NCCL5SKhNL4l82njobxmuZ96C6M8BqCmAPfoghGjzgiTkMGL5CbeElsSmapRpBSp5drGLgz4DwWAqA==;5:n5NLiJ0rs1vr7CUlaSWpbOZ1pwfaA0fZ+Km7sw+rbMfR7ST/lgHxAKAO2iwmaojd+2ZY0mhwPvnKUtGVYTEPvTjPxAhb81mX4l+A7Hdsv0Cyq4wbK0RXT6os9rUw6Po9bRuw8Q/bL4bPji+7YiYNQg==;24:qqxTnbkAFkfIkvrrdIaAFutCn+JpBBLtkIJqsJA+F96M13Mj/weMUmX+aw75iS++1GZ05QWnxV1oUBlIGQZO/2ojJERmzzWCVpXdi+PBCpE=;7:EnE0BugIGG7QdjQgLafca0e6+O/CtXnzbgG3k2pEXdYJquDFZv3g8NB//gR/tUaaqV7y+uWpz0qnZmBsDNcZ11/MXfueOrMCmCDqEsfVPsdsYVIuxFrVgjpN0/HWvCVMfOrAKEUFqGtzeHXy/sky6oCgjDLURfwhlSEO1auOD7xrbMiRFT8S4znrVr9oW/FxserqgR9hU7P0s0gxTAhJJqp8fW36iDfdFyduV3BXxMUHqU3QTf7G8qeg7Hk4m5sqF+DCvU3XU5d3vWphmU2zdkBKoBj9wE7rQQDj3A06uVpasYhW+xyHfMm+i5/ed6/J SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1505 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(51914003)(199003)(189002)(377454003)(24454002)(33716001)(8666005)(105606002)(189998001)(16796002)(6666003)(106466001)(3720700001)(6070500001)(54356999)(53416004)(356003)(76176999)(4001350100001)(47776003)(50986999)(97736004)(956001)(66066001)(2906002)(87936001)(305945005)(5660300001)(85426001)(50466002)(7736002)(7416002)(626004)(9576002)(336002)(9686002)(8936002)(46406003)(6116002)(92566002)(3846002)(586003)(83506001)(23726003)(77096005)(81166006)(8676002)(110136003)(19580405001)(19580395003)(81156014)(86362001)(4326007)(68736007)(42882006)(6916009)(2950100002)(7846002)(86152002)(7099028)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB491;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC010;1:i0OA/elOyZ51DF6wiUeYrMfbGUyicrof7nutDtGVL7023CgY+zK8rVfl6bvfrsaCehmYOLtE/ygWuaQdwU3iR0pwgUlPvvvW9CC/sRnjxgSBMk0p2J4e8JutAaWqULpXc4Fz4EgsabD9grewmIRX+E0+BCVB25v6pWJjhh75gW3IAIFihMK+8d7eGrUDP45O1lHpNxa6ZThaxBwCrfV9b+mSPgSjGrRhxOet2zD5Fp2SDe7V0mG8jrtqqQq+FAyryjtrpQwtjeQmtrZw8J2COToPhAjs0Ex5nmTnOHPtlpOvHhEb2Eh7KjjH9SdCWci56INEUeieKA7y8pVRqAnulUA0t1U4tsgXYW8Le0JMBkLHKcyqlPHfjadFF6iB4qysVvWaOfuwT2iGGQiA8WZfzcOOSl44kpA4f2X42PzbOkZrk7jvI48GhNW4HzMb1DGptVw89vUunOMvj1HE7hEh0JS44NpBZ6m2JH4Ac/WJImSEUFv8H7ZDGKre6fLQsv5gm80N6G4sRo+auPyRAYGH2jYfYnBXa6BKzNJU6ZUjmmiTcMkYneeKin74+sHPXV/b3ZgpTMrQZZqTBFtiY9pOteBw3axFUFDztGUpAEGbAQE= X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11OLC010.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB491;2:9qC27iAv9rm4nyGXCsxEKCx/Po+s9ZKWGpk0UmIFA2kiJ1yTnX5NymWuaI+G8Tw9gZ+ezgTmBSNBk6KylOaUaTQ48lCOUb36EvLOLn1va2Kbfp8bpr9SPv+hW0tm09No7iNWcppdEQeB7hC10WG3KIVkvru8NvP+YSB5eltC5JuxM4D4W8R59lMGMfiXMvt8Heh3GeiaFoSKDmkMqG8lDw==;3:ZLIIDH9Udr5CWXW0hrbfuv7n1LDDR/g2Z3UYaMwfAvlfxtgiXywgiVuwGJeDLDYO0V+tigEfTICbytFrr/DgzhOESwFEIILzvEO2bzZU6MNDlq65dCMZzqlwAWVBRWDfZ0COcLyrqjFaIfeh7baVnwaDQ+0iyiJn0N9k8Hf4oyVPKtTwkE7D0iwMEbQjbPMfjvsrPmt/TJQGS0AqGdiZCaSTDyaK4YqlhV2atQh6xfabrAqPn/6dcvsLwHJwiV0AlZeXTmIVy4U3YKtUghhRKA==;25:AFx0UOcyqTpmwLYhZ/ZZc2QjLUFobW0aSekbiEO0yLAan4xSuq4h4oFCRN8R031J6Vi3lG3xFGsQpQIwSZuo3do9Mr2u3KsdMjLkXA5kpQTKTPdPE2LJrUprF85ZSSpZPD8Zkuyo5+X45R37KBKM7/eNu0nB2wE+uCVRrtb8wZD/Vj/mLtluIMWDkqoenfR5yW+9eObCkHRcStXY+uSWio+MOWoozspzPXLYJ81MkrB38IwSwQRsWi9E3OJB5mwTgVyVIkOCA0lnuKx/i8OGTYc+o1TUIopqJNOmqwBtoTr8RqLnT3/eGwXpMgtiGnCiIPUPS7mN8uekA4Ho7x7YI9n0ho7w59n4FEW7PpPQ2BWRJ8oCJEbFv3XjuX3WLzvymhE8kiqlyQvMp9J0vYhObM3EqK3nPitXf+J04lEYQpTGmXB1d/ay91nB/ZtrMcmG X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BY2PR03MB491; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB491;31:9SUZYVnq+NQiVOdpysxfeegyNY0LWsaE5afy6lODJWb1knbsOZ2LBPcaQy+2I98m35Oh9auH2w5EwVHHqUMGY0/7kNFD9Hm+4eG/2S1zcF3/uihHk+vMqbtLyrSonqEOZDg4jsgH9E4VfLvld9iGy4U8qMKh6lTArQ05iuqR9cQAzPDhAXgMLoxveqX9bV8PNG0MpO6zgA7dDk4Vv2Jr1VNngDqtUC84LCEDQK8hXfI6A4GA/gi25GCIGtmYeiKk;20:lKH2xSAouuxEEzAidqX2U4N2oNMBU1S45gTtjemgPxmnhcJlCW7SwuXsQUio3+X/YnYsKDzk2rQZ37BzL7ECrjP5+z8ErmMSAJOtN5t7FIIaoLLZTq/Q2/YvXQ7cDrbXQgr36e3Pq1TOYBW/00RqgGaYT0S4eSDn6TCdxwtmcgc= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB491;4:7O8mqTAgJisNNYGmESUXygAnz9mSps5LSqYXJoYu++Jr4uMM006UFGg6iVjzbxNIQhM/F2IrKxTbFaimyZu+TTtJ8hWtxb1lDaXe8a1AZJHCb3DLBGGWDrxPhCykVTYNaBrPFiIvuVLVrLRQxcfcLTv4/pf57feuXhL2a0yDNo6ajYxEAlfymJ2C//iYFM/YGZlLTeDAcxkf3sN72iVkYXroBthQNmdzuxQOQo8wEEVdThTXAFet29OXmcacuLwcQDqh5hXJXuD431eZ7WwWRrx/yuJuVP2ouu6ZU3PFi6h3HrnMvmlVUi/DCk6iqk8aD41urg9D2vBdJSUDj3R6Lm6gXipY7p8KmevI2PCtoY95N6Q1dW/fK0r5AB8yvsPPwMMBy7b7qubV1mjRpgEg2NgOYZabP8DwuWkVtnKvvh1AAU8qfdh2Ixk/DjHKCCyEzSKaFdjw0J1qUsJ2h2RUq6U4p7J/yWILkffhZsHXE7JNLpNScmgJdMxKCE08OIoagXhgYnXButo45gRPdnra+0b2HdrRn9doSbgySwzo2njzxgLK4HkKIh5ZCzcjBP+3 X-Forefront-PRVS: 00808B16F3 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR03MB491;23:ryCI+eTXSJ25hNoMNpoYCG+VbcqGy2h7TVPrdjtDhR?= =?us-ascii?Q?V+YIz+98zrvC2Qe24XqAklAKhQ5HFbYTNNqrBGilcF115xSO8yyOM6axqfJ1?= =?us-ascii?Q?xwRi/iJuwWLA4EU95Plhfk4J+r+iv4gKShg9YhVbhX8GwpS110GZY3fycf5y?= =?us-ascii?Q?a+MpEj/bnnzImBI7oTIpZWRi9W4/4BxqrzKqKokB4QRzkBg9DjP6VEF+9fUS?= =?us-ascii?Q?bo0Mye+wvoC4sFnqeH9Ex6qtTAT2Fo+xp53QZuVKXRg1ONsLPx1v7UATgpi5?= =?us-ascii?Q?yWXZMfzsQ02xctYDaVBmEpt0S3khKniLb4c95Fk0asmUFWDuYP766jIeVvvK?= =?us-ascii?Q?2/FRsSeApZVsImlyVubfmrk3QtjFik6d44jY/8afWkhs35EWMPJAYa+nuK3p?= =?us-ascii?Q?AnYWBSeCm6hDCt8/C7GhQUAd85MI6XztSn0RZHxDFOG3Umj1GUZta9TR/L4T?= =?us-ascii?Q?A9AFV10DnX1LYGj+HJaX/GUnrq+SXGnlixWlbsDyNymodwigdsiq7UehCOu2?= =?us-ascii?Q?FhrMWqBerY/s4jhgLmS5SvouRsDacuwL8OqbLZb+d2Dx65FjLcgVFZeP+2CS?= =?us-ascii?Q?Wye2U0j1p+ROf6cU42u4fyCkTLK0AaodpTOHTXXDB0FTPEUg/a/vXFgX5q4x?= =?us-ascii?Q?1usBA5Uk0f/P1ZhBrwXo8TcWFjJ7MPlv0zxxfMfoQSvk15icNICy7FbNTRP0?= =?us-ascii?Q?luvPGwpKwFgabK6KHwakhqZH2Ea8nNabFLBLsLewgf/+fUhpPPs4uJWryqbY?= =?us-ascii?Q?Qns60uDHgSv6/6/qJnT3ISK5AYkMTCJhrWK/XVpqyVEqSWu7gbXHSfgnBek0?= =?us-ascii?Q?zhmsFP+PtGRB85kA3APNxUvMM5DScjp9WEmXJOL2o4ADwE79fqP1FRSBcsva?= =?us-ascii?Q?IHchJx0g2DF8BVlzo2tsEBhJQ7OUOp3ABajKfvfPr6V/z1rLbpPSRtO+ZvZd?= =?us-ascii?Q?eQUr3AMixVt4Yu7/8y6kFvWMRgVV1M1DO/c3qSUHmx0VGrZCPA99bDuCcR6b?= =?us-ascii?Q?9KKidmVg1UtT44txGV2+g+QPGojCWtH3FFwDPTcHf87K8PhJYxBiYnnGjIxL?= =?us-ascii?Q?3qPmEdb/DBcCQWLzittcqdprh1IQCFkhr91XRE8CtMgvrz/tw0h4s13n5Aw6?= =?us-ascii?Q?Hq3xRSCXFhmZ0pym1dHevzLOtVSb1bzYIwW06fcxetdekYmyTm44BM+czGyt?= =?us-ascii?Q?WCPEdPJ+m/BpyzPYZGyOpfCG8q8da8+ib9iRk2f/6Ipr0fOGqz3+mV1Lvtwn?= =?us-ascii?Q?hGOfDDdjEVgKCGcE6r/4VYV9SnWAlKjUvF4CVZVt6QwfxVy18FOh3b2blSkQ?= =?us-ascii?Q?S2s2gBHbs3+5q41v7NeoKX1cEstg62WU7eO1fsB9ZSwOwQlfg8foQxavWz3P?= =?us-ascii?Q?LlJzBRq2pvOLRcPF2LGSVgT8PCXBhNxK5/+H1SqhdOFJoIcUlWGDlDNA2xmr?= =?us-ascii?Q?YAGZlGuFe7l9/kqsh4W+s+3v6xokgTaZrnKBl4J/WkDTeiUaQXW+PqYx1g8v?= =?us-ascii?Q?C2C2nDksfDq5CJkaO894oitfe6gGX22IJGkbPSQKKiNBdY36boa+Cp?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB491;6:8RsYhMskehIp6vuNT/lP//qlPWAC85Uu9SyXOcT1HjhI13XXl9+FUx0b6x6IAgBhVmdJe9RysGTIW6vFWNJ6NzZcKTWDxCqIBwsWUgbHCDp1gubwnAYzMGl0vsFmVQGqUmZT22kjYrbDI73OvvArPs6jjcX2qcdR7r5fVQx6aH9yMgzKN4u7AsnAIsDwRnmmRVM6Msyu8X1mgu7GgyAhxs8FNT9FhC221FsvCtP0pt0ckwOBGB7DkKB97EYX7Aby6+bkmL5nSGKm48T/5dMWIaT9oDg7oYxThVWQlirpiOuf3/vBOYTO+2Po753/toRwZzYK3EnvsJzS/4jLAWkNXQe1Nkrv1rk/SAJzklwzm6Y=;5:rcRwSvqUytdJbJJf+HyK1Vj1l5aX4daD7+KTY2lodzqhFgOnm8XZMgi66f4XDvneVUfeDizc7RQjX9jZ9bnHBcXAEhGQvALUwfKDXv0eLMxbotYJH/+hXKDaYRRpu/8AaHeQ6cCvBYuPnBTGgpgTBaXBXULk/G1FrPQnjaYeKAE=;24:A7HKajgIhy5r/gLy4cgPqoSiog4rbR/Fn+go1kzTda4CZnU1UFpFALhW4hpul5m10ue8iw2Ed5fKMOG0t4480+Mk10fYGTKJlWu6cBBcrV8=;7:xjQD2Hf7NNV1KAu15v6edfLxPg/pMRYABCp6qiLgfAJs6jJe52kHjEM8R7JRf4xH3QiTufTrmJBDYwF4UqY8I+Gdwnb9yVBGcv71QHB77841McWZzZgqUWqUjbXAL6dFsqbGKic3wSUpUnRj7Nrtmfm7uh5XNiYDzplVlhVE0t4YBtzCd1C/v9EFYn0VSttAmvKV4De1Zln+e02iWDo+c2mrepo2+ewMW5yVW5AnUCv5fmAa3Bln2g7a8r4pE/EEd4X6vsFuQtU8XiLbAVzhsyXdGZQXURyl0+sbv1Ir1JU= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2016 21:35:20.5103 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB491 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Sep 2016, Moritz Fischer wrote: > Hi Alan, > > On Wed, Sep 28, 2016 at 11:22 AM, Alan Tull wrote: > > > +static void socfpga_a10_fpga_generate_dclks(struct a10_fpga_priv *priv, > > + u32 count) > > +{ > > + u32 val; > > + unsigned int i; > > + > > + /* Clear any existing DONE status. */ > > + regmap_write(priv->regmap, A10_FPGAMGR_DCLKSTAT_OFST, > > + A10_FPGAMGR_DCLKSTAT_DCLKDONE); > > + > > + /* Issue the DCLK regmap. */ > > + regmap_write(priv->regmap, A10_FPGAMGR_DCLKCNT_OFST, count); > > + > > + /* wait till the dclkcnt done */ > > + for (i = 0; i < 100; i++) { > > + regmap_read(priv->regmap, A10_FPGAMGR_DCLKSTAT_OFST, &val); > > + if (val) > > + break; > > + udelay(1); > > + } > > It's quite new, but regmap_read_poll_timeout() might be a good fit here? Yes > > > +static int socfpga_a10_fpga_encrypted(struct fpga_manager *mgr, > > + u32 *buf32, size_t buf32_size) > > +{ > > + int encrypt; > > + > > + if (buf32_size < 70) > > + return -EINVAL; > > + > > + encrypt = ((buf32[69] >> 2) & 3) != 0; > > + > > + dev_dbg(&mgr->dev, "header word %d = %08x encrypt=%d\n", > > + 69, buf32[69], encrypt); > Maybe a named constants for magic 69 / 70 value :) Sure > > > +static int socfpga_a10_fpga_compressed(struct fpga_manager *mgr, > > + u32 *buf32, size_t buf32_size) > > +{ > > + int compress; > > + > > + if (buf32_size < 230) > > + return -EINVAL; > > + > > + compress = !((buf32[229] >> 1) & 1); > > + > > + dev_dbg(&mgr->dev, "header word %d = %08x compress=%d\n", > > + 229, buf32[229], compress); > > + > > + return compress; > > +} > Same here, a comment on 229/230 would work too I guess. > > > +/* Start the FPGA programming by initialize the FPGA Manager */ > > +static int socfpga_a10_fpga_write_init(struct fpga_manager *mgr, > > + struct fpga_image_info *info, > > + const char *buf, size_t count) > > +{ > > + struct a10_fpga_priv *priv = mgr->priv; > > + unsigned int cfg_width; > > + u32 msel, stat, mask; > > + int ret; > > + > > + if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) > > + cfg_width = CFGWDTH_16; > > + else > > + return -EINVAL; > > So we can *only* do partial reconfig? Am I missing something here? Correct, only PR for now. > > > + /* Do some dclks, wait for pr_ready */ > > + socfpga_a10_fpga_generate_dclks(priv, 0x7ff); > > Maybe a named constant? OK. Thanks for the review! Alan > > Cheers, > Moritz >