From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755804AbaHZW3g (ORCPT ); Tue, 26 Aug 2014 18:29:36 -0400 Received: from www.linutronix.de ([62.245.132.108]:57291 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbaHZW3f (ORCPT ); Tue, 26 Aug 2014 18:29:35 -0400 Date: Wed, 27 Aug 2014 00:29:21 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: peterz@infradead.org, linux-kernel@vger.kernel.org, mingo@kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf In-Reply-To: <20140826212934.GP4120@two.firstfloor.org> Message-ID: References: <1409006611-30741-1-git-send-email-andi@firstfloor.org> <1409006611-30741-2-git-send-email-andi@firstfloor.org> <20140826212934.GP4120@two.firstfloor.org> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Aug 2014, Andi Kleen wrote: > > So what's the point of making the obvious onliner patch > > > > - case 71: > > > > into something which reorders the sorted case numbers? > > This was a merging mistake. I'll fix it to be a one liner. > > > And of course, this patch is missing any explanation WHY 71 is > > incorrect and how it got there in the first place. > > 71 is a Broadwell, as you would know if you had read the next patch. And why on earth do I need to read the next patch to figure out what the heck this patch is doing? Just because it's written by someone who gives a shit? Your unwillingness to cooperate and your advisory resistance are slowly approaching the Krause level... Thanks, tglx