From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757986AbaJaSLe (ORCPT ); Fri, 31 Oct 2014 14:11:34 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:4893 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbaJaSLc (ORCPT ); Fri, 31 Oct 2014 14:11:32 -0400 X-IronPort-AV: E=Sophos;i="5.07,295,1413237600"; d="scan'208";a="104019374" Date: Fri, 31 Oct 2014 19:11:30 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle Subject: Re: [PATCH resent] staging: rtl8188eu: Deletion of unnecessary checks before three function calls In-Reply-To: <5453D013.9000007@users.sourceforge.net> Message-ID: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5453D013.9000007@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Oct 2014, SF Markus Elfring wrote: > >> The functions kfree(), rtw_free_netdev() and vfree() test whether their > >> argument is NULL and then return immediately. Thus the test around the call > >> is not needed. > >> > >> This issue was detected by using the Coccinelle software. > >> > >> Signed-off-by: Markus Elfring > >> --- > >> drivers/staging/rtl8188eu/core/rtw_efuse.c | 3 +-- > >> drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +-- > >> drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 3 +-- > >> drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 ++---- > >> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 5 ++--- > >> 5 files changed, 7 insertions(+), 13 deletions(-) > >> > >> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c > >> b/drivers/staging/rtl8188eu/core/rtw_efuse.c > >> index 7006088..77f7552 100644 > >> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c > >> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c > >> @@ -212,8 +212,7 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 > >> _size_byte, u8 *pbuf) > >> exit: > >> kfree(efuseTbl); > >> > >> - if (eFuseWord) > >> - kfree(eFuseWord); > >> + kfree(eFuseWord); > > > > I think that this code has been updated already. It would be better to > > add labels so that kfree is only executed when needed. > > Are there any chances to achieve the suggested fine-tuning for jump labels > also with another semantic patch approach? No, I don't think so. The pattern is not regular enough. julia