From: David Rientjes <rientjes@google.com>
To: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
Cc: Lukasz Pawelczyk <havner@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Michal Hocko <mhocko@suse.cz>,
Sameer Nanda <snanda@chromium.org>,
Guillaume Morin <guillaume@morinfr.org>,
Li Zefan <lizefan@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/exit.c: make sure current's nsproxy != NULL while checking caps
Date: Mon, 1 Dec 2014 13:08:46 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1412011307450.16984@chino.kir.corp.google.com> (raw)
In-Reply-To: <1417086070.1805.9.camel@samsung.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1588 bytes --]
On Thu, 27 Nov 2014, Lukasz Pawelczyk wrote:
> On śro, 2014-11-26 at 13:32 -0800, David Rientjes wrote:
> > On Wed, 26 Nov 2014, Lukasz Pawelczyk wrote:
> > >
> > > LSM task_kill() hook is triggered and current->nsproxy within is NULL.
> > >
> > > This happens during an exit() syscall because exit_task_namespaces() is
> > > called before the exit_notify(). This patch changes their order.
> > >
> >
> > This is a classic case of a patch being proposed for a problem that only
> > occurs on kernels that include other patches that are not upstream. The
> > order that things are deconstructed in the exit path is complex and
> > carefully choreographed, changing it comes at significant risk. That risk
> > would be justified if a patch were being proposed for upstream that fixes
> > an upstream problem. It becomes too much of a maintenance nightmare to
> > try to address problems and keep issues from arising for non-upstream
> > patches. Thus, I don't think this is something that we want.
>
> This is a problem for the change I'm working on and I will be
> upstreaming it too at some point. Please see my other reply for more
> details:
>
> http://www.spinics.net/lists/kernel/msg1877152.html
>
> The only thing I can do then is to post this patch together with the
> other patches when the time comes. But since this issue is rather
> separate I've decided to try to push it earlier.
>
Yeah, it would be best to fold this into a series that needs
current->nsproxy to be valid at a sequence point in the exit path as part
of the same patch that requires it.
prev parent reply other threads:[~2014-12-01 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 14:21 [PATCH] kernel/exit.c: make sure current's nsproxy != NULL while checking caps Lukasz Pawelczyk
2014-11-26 20:52 ` Oleg Nesterov
2014-11-27 10:55 ` Lukasz Pawelczyk
2014-11-26 21:32 ` David Rientjes
2014-11-27 11:01 ` Lukasz Pawelczyk
2014-12-01 21:08 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1412011307450.16984@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=guillaume@morinfr.org \
--cc=havner@gmail.com \
--cc=l.pawelczyk@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=snanda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).