From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbbFHQVo (ORCPT ); Mon, 8 Jun 2015 12:21:44 -0400 Received: from mga03.intel.com ([134.134.136.65]:12969 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685AbbFHQVg (ORCPT ); Mon, 8 Jun 2015 12:21:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,574,1427785200"; d="scan'208";a="584132336" Date: Mon, 8 Jun 2015 09:20:12 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, matt.fleming@intel.com, will.auld@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT In-Reply-To: Message-ID: References: <1433462497-27087-1-git-send-email-vikas.shivappa@linux.intel.com> <1433462497-27087-9-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Jun 2015, Thomas Gleixner wrote: > On Sat, 6 Jun 2015, Thomas Gleixner wrote: > >> On Thu, 4 Jun 2015, Vikas Shivappa wrote: >>> +static inline void intel_rdt_sched_in(void) >>> +{ >>> + if (static_key_false(&rdt_enable_key)) >>> + __intel_rdt_sched_in(); >> >> So if the enable_key is FALSE we call the RDT stuff? I might be >> missing something important, but this does not make any sense and I >> have to ask how that whole stuff has been tested. > > Bah. That static key API is really designed for maximal confusion. The > above is correct, but a comment might not be the worst thing. Ah yes, - its also tested with debug prints. Will add comment. Thanks, Vikas > > Thanks, > > tglx >