From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbbFKJ4M (ORCPT ); Thu, 11 Jun 2015 05:56:12 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:15581 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbbFKJ4B (ORCPT ); Thu, 11 Jun 2015 05:56:01 -0400 X-IronPort-AV: E=Sophos;i="5.13,594,1427752800"; d="scan'208";a="164502360" Date: Thu, 11 Jun 2015 11:55:50 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sergey Senozhatsky cc: Julia Lawall , Joe Perches , Andrew Morton , Sergey Senozhatsky , Minchan Kim , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Michal Hocko , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] checkpatch: Add some _destroy functions to NEEDLESS_IF tests In-Reply-To: <20150611095144.GC515@swordfish> Message-ID: References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> <20150609142523.b717dba6033ee08de997c8be@linux-foundation.org> <1433894769.2730.87.camel@perches.com> <1433911166.2730.98.camel@perches.com> <1433915549.2730.107.camel@perches.com> <20150611095144.GC515@swordfish> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Jun 2015, Sergey Senozhatsky wrote: > On (06/11/15 11:41), Julia Lawall wrote: > > On Tue, 9 Jun 2015, Joe Perches wrote: > > > > > Sergey Senozhatsky has modified several destroy functions that can > > > now be called with NULL values. > > > > > > - kmem_cache_destroy() > > > - mempool_destroy() > > > - dma_pool_destroy() > > > > I don't actually see any null test in the definition of dma_pool_destroy, > > in the linux-next 54896f27dd5 (20150610). So I guess it would be > > premature to send patches to remove the null tests. > > > > yes, > > Andrew Morton: > : I'll park these patches until after 4.1 is released - it's getting to > : that time... OK, thanks, julia