From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755130AbbLKMPA (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Dec 2015 07:15:00 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7408 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754770AbbLKMO6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Dec 2015 07:14:58 -0500
X-IronPort-AV: E=Sophos;i="5.20,413,1444687200"; 
   d="scan'208";a="191551905"
Date: Fri, 11 Dec 2015 13:14:51 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: SF Markus Elfring <elfring@users.sourceforge.net>
cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        "Derek M. Jones" <derek@knosof.co.uk>
Subject: Re: Source code review around jump label usage
In-Reply-To: <566ABCD9.1060404@users.sourceforge.net>
Message-ID: <alpine.DEB.2.10.1512111312330.2494@hadrien>
References: <566ABCD9.1060404@users.sourceforge.net>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Do any of these numbers indicate update candidates which correspond to the
> "one error jump label bug" symptom that is mentioned in the Linux coding
> style documentation?

I don't think that numbers could indicate that.  The point of that is a
single label followed by a bunch of ifs, or by calls to functions that
perform tests on input validity.  That is, it is the content of the code
that causes the problem, not its size.  Dan also discourages the use of
labels like out, that don't indicate anything about anything, or
kmalloc_err, which don't indicate anything about what happens at the label
target.

julia