From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754051AbcERUc4 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 May 2016 16:32:56 -0400
Received: from mx1.scotdoyle.com ([23.226.141.211]:33993 "EHLO
	mx1.scotdoyle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752662AbcERUcy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 May 2016 16:32:54 -0400
X-Greylist: delayed 502 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 May 2016 16:32:54 EDT
Date: Wed, 18 May 2016 15:24:26 -0500 (CDT)
From: Scot Doyle <lkml14@scotdoyle.com>
To: David Daney <david.daney@cavium.com>, Ming Lei <ming.lei@canonical.com>,
        Dann Frazier <dann.frazier@canonical.com>
cc: Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, Peter Hurley <peter@hurleysoftware.com>,
        David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org,
        "Chintakuntla, Radha" <Radha.Chintakuntla@caviumnetworks.com>,
        David Daney <ddaney.cavm@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Subject: Re: [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer.
In-Reply-To: <CACVXFVPdjfFkRFucTQsOHsVFtgm1W0JtOTqjyDzyNbzygghUyg@mail.gmail.com>
Message-ID: <alpine.DEB.2.10.1605181519540.8967@laptop>
References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> <20160517204912.GA29719@amd> <CACVXFVPdjfFkRFucTQsOHsVFtgm1W0JtOTqjyDzyNbzygghUyg@mail.gmail.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 18 May 2016, Ming Lei wrote:
> On Wed, May 18, 2016 at 4:49 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Tue 2016-05-17 11:41:04, David Daney wrote:
> >> From: David Daney <david.daney@cavium.com>
> >>
> >> We are getting somewhat random soft lockups with this signature:
> >>
> >> [   86.992215] [<fffffc00080935e0>] el1_irq+0xa0/0x10c
> >> [   86.997082] [<fffffc000841822c>] cursor_timer_handler+0x30/0x54
> >> [   87.002991] [<fffffc000810ec44>] call_timer_fn+0x54/0x1a8
> >> [   87.008378] [<fffffc000810ef88>] run_timer_softirq+0x1c4/0x2bc
> >> [   87.014200] [<fffffc000809077c>] __do_softirq+0x114/0x344
> >> [   87.019590] [<fffffc00080af45c>] irq_exit+0x74/0x98
> >> [   87.024458] [<fffffc00080fac20>] __handle_domain_irq+0x98/0xfc
> >> [   87.030278] [<fffffc000809056c>] gic_handle_irq+0x94/0x190
> >>
> >> This is caused by the vt visual_init() function calling into
> >> fbcon_init() with a vc_cur_blink_ms value of zero.  This is a
> >> transient condition, as it is later set to a non-zero value.  But, if
> >> the timer happens to expire while the blink rate is zero, it goes into
> >> an endless loop, and we get soft lockup.
> >>
> >> The fix is to initialize vc_cur_blink_ms before calling the con_init()
> >> function.
> >>
> >> Signed-off-by: David Daney <david.daney@cavium.com>
> >> Cc: stable@vger.kernel.org
> >
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> Tested-by: Ming Lei <ming.lei@canonical.com>
> 
> Thanks David and Pavel for making it work!
> 
> >
> > (And it is amazing how many problems configurable blink speed caused).
> >
> > Thanks!
> >                                                                 Pavel
> >


Dann, Ming and David, thank you so much for all of your effort.

There were three other reports in the past year, each leading to their own 
patch, of boot lockups occuring when the cursor flash timer was set using 
an ops->cur_blink_jiffies value of 0.  I plan to propose a patch within 
the next day that will prevent this for all code paths.