From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751395AbcETUqa (ORCPT ); Fri, 20 May 2016 16:46:30 -0400 Received: from smtp2.kfki.hu ([148.6.0.28]:52008 "EHLO smtp2.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcETUq2 (ORCPT ); Fri, 20 May 2016 16:46:28 -0400 X-Greylist: delayed 419 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 May 2016 16:46:28 EDT Date: Fri, 20 May 2016 22:40:47 +0200 (CEST) From: Jozsef Kadlecsik To: Muhammad Falak R Wani cc: "David S. Miller" , Pablo Neira Ayuso , Patrick McHardy , Vishwanath Pai , Joshua Hunt , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] netfilter: ipset: use setup_timer() and mod_timer(). In-Reply-To: <1463173145-16167-1-git-send-email-falakreyaz@gmail.com> Message-ID: References: <1463173145-16167-1-git-send-email-falakreyaz@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 May 2016, Muhammad Falak R Wani wrote: > Use setup_timer() and instead of init_timer(), being the preferred way > of setting up a timer. > > Also, quoting the mod_timer() function comment: > -> mod_timer() is a more efficient way to update the expire field of an > active timer (if the timer is inactive it will be activated). > > Use setup_timer() and mod_timer() to setup and arm a timer, making the > code compact and easier to read. > > Signed-off-by: Muhammad Falak R Wani > --- > net/netfilter/ipset/ip_set_bitmap_gen.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) The patch and the other too in the series as well are applied in the ipset git repository and will be submitted for kernel inclusion. Thanks. Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary