From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933439AbcFHWvY (ORCPT ); Wed, 8 Jun 2016 18:51:24 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:35804 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932290AbcFHWvW (ORCPT ); Wed, 8 Jun 2016 18:51:22 -0400 Date: Wed, 8 Jun 2016 15:51:20 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Michal Hocko cc: Oleg Nesterov , linux-mm@kvack.org, Tetsuo Handa , Vladimir Davydov , Andrew Morton , LKML Subject: Re: [PATCH 06/10] mm, oom: kill all tasks sharing the mm In-Reply-To: <20160608062219.GA22570@dhcp22.suse.cz> Message-ID: References: <1464945404-30157-1-git-send-email-mhocko@kernel.org> <1464945404-30157-7-git-send-email-mhocko@kernel.org> <20160606232007.GA624@redhat.com> <20160608062219.GA22570@dhcp22.suse.cz> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jun 2016, Michal Hocko wrote: > > Why is the patch asking users to report oom killing of a process that > > raced with setting /proc/pid/oom_score_adj to OOM_SCORE_ADJ_MIN? What is > > possibly actionable about it? > > Well, the primary point is to know whether such races happen in the real > loads and whether they actually matter. If yes we can harden the locking > or come up with a less racy solutions. A thread being set to oom disabled while racing with the oom killer obviously isn't a concern: it could very well be set to oom disabled after the SIGKILL is sent and before the signal is handled, and that's not even fixable without unneeded complexity because we don't know the source of the SIGKILL. Please remove the printk entirely.