From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbcFULaG (ORCPT ); Tue, 21 Jun 2016 07:30:06 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:15278 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbcFULaD (ORCPT ); Tue, 21 Jun 2016 07:30:03 -0400 X-IronPort-AV: E=Sophos;i="5.26,503,1459807200"; d="scan'208";a="181982087" Date: Tue, 21 Jun 2016 13:17:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Yann Droneaud cc: Michal Marek , Gilles Muller , Nicolas Palix , Tejun Heo , Greg Kroah-Hartman , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Johannes Weiner Subject: Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues In-Reply-To: <1466507681.30939.14.camel@opteya.com> Message-ID: References: <5767EE79.5090402@suse.com> <57690C52.7080207@suse.com> <1466507681.30939.14.camel@opteya.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1593695348-1466507855=:2882" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1593695348-1466507855=:2882 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 21 Jun 2016, Yann Droneaud wrote: > Hi, > > Le mardi 21 juin 2016 à 11:43 +0200, Michal Marek a écrit : > > Dne 20.6.2016 v 22:21 Julia Lawall napsal(a): > > > On Mon, 20 Jun 2016, Michal Marek wrote: > > > On 2016-05-23 17:18, Julia Lawall wrote: > > > > > On Mon, 23 May 2016, Yann Droneaud wrote: > > > > > > > > > > > Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'), > > > > > > kfree() is no more the only function to be considered: > > > > > > kzfree() should be recognized too. > > > > > > > > > > > > In particular, kzfree() must not be called on memory > > > > > > allocated through devm_*() functions. > > > > > > > > > > > > Cc: Johannes Weiner > > > > > > Signed-off-by: Yann Droneaud > > > > > > > > > > Acked-by: Julia Lawall > > > > > > > > Hi Julia, > > > > > > > > does your ACK apply to the other two patches as well? > > > > > > Sorry, I seem to have missed the other two.  I have reviewed them > > > now, and the ack applies to all three.  Thanks for checking on it. > > > > Back in February, those two other patches were already Acked-by: > > http://lkml.kernel.org/r/alpine.DEB.2.10.1602161818100.2685@hadrien > http://lkml.kernel.org/r/alpine.DEB.2.10.1602161819340.2685@hadrien > > I've (re)sent them with added Acked-by:, and thought it would not > require further Acked-by:. > > Anyway, this one was new and required proper review. Thanks a lot. Thanks for the reminder. Since they are comitted now, things are going in the right direction. julia --8323329-1593695348-1466507855=:2882--