From: David Rientjes <rientjes@google.com>
To: Ganesh Mahendran <opensource.ganesh@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com
Subject: Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj
Date: Tue, 21 Jun 2016 13:27:40 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1606211326120.28466@chino.kir.corp.google.com> (raw)
In-Reply-To: <1466487018-5410-1-git-send-email-opensource.ganesh@gmail.com>
On Tue, 21 Jun 2016, Ganesh Mahendran wrote:
> om_adj is deprecated, and in lowmemorykiller module, we use score adj
> to do the comparing.
> ---
> oom_score_adj = p->signal->oom_score_adj;
> if (oom_score_adj < min_score_adj) {
> task_unlock(p);
> continue;
> }
> ---
>
> This patch makes the variable name consistent with the usage.
>
Umm, I don't think you can just remove a parameter to a module and replace
it with something that has a different unit and not think that userspace
will break as a result.
next prev parent reply other threads:[~2016-06-21 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 5:30 [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj Ganesh Mahendran
2016-06-21 5:30 ` [PATCH 2/3] staging: lowmemorykiller: count anon pages only when we have swap devices Ganesh Mahendran
2016-06-21 20:22 ` David Rientjes
2016-06-22 3:27 ` Ganesh Mahendran
2016-06-23 8:42 ` Sergey Senozhatsky
2016-07-01 2:02 ` Ganesh Mahendran
2016-06-21 5:30 ` [PATCH 3/3] staging: lowmemorykiller: select the task with maximum rss to kill Ganesh Mahendran
2016-06-21 20:14 ` David Rientjes
2016-06-22 4:44 ` Ganesh Mahendran
2016-06-21 20:27 ` David Rientjes [this message]
2016-06-22 3:10 ` [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj Ganesh Mahendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606211326120.28466@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.ganesh@gmail.com \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).